Skip to content

UPSTREAM PR #17799: metal : fix build #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loci-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UPSTREAM PR #17799: metal : fix build #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions ggml/src/ggml-metal/ggml-metal-device.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,22 +574,26 @@ ggml_metal_rsets_t ggml_metal_rsets_init(void) {
// the requests stop after a certain amount of time (keep_alive_s) of inactivity
dispatch_queue_t d_queue = dispatch_get_global_queue(QOS_CLASS_DEFAULT, 0);
dispatch_group_async(res->d_group, d_queue, ^{
while (!atomic_load_explicit(&res->d_stop, memory_order_relaxed)) {
if (atomic_load_explicit(&res->d_loop, memory_order_relaxed) > 0) {
[res->lock lock];
#if defined(GGML_METAL_HAS_RESIDENCY_SETS)
if (@available(macOS 15.0, iOS 18.0, tvOS 18.0, visionOS 2.0, *)) {
while (!atomic_load_explicit(&res->d_stop, memory_order_relaxed)) {
if (atomic_load_explicit(&res->d_loop, memory_order_relaxed) > 0) {
[res->lock lock];

for (int i = 0; i < (int) res->data.count; ++i) {
[res->data[i] requestResidency];
}
for (int i = 0; i < (int) res->data.count; ++i) {
[res->data[i] requestResidency];
}

atomic_fetch_sub_explicit(&res->d_loop, 1, memory_order_relaxed);
atomic_fetch_sub_explicit(&res->d_loop, 1, memory_order_relaxed);

[res->lock unlock];
}
[res->lock unlock];
}

// half a second
usleep(500 * 1000);
}
// half a second
usleep(500 * 1000);
}
}
#endif
});

return res;
Expand Down