Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

TypeScript branch #161

Closed
ctoran opened this issue Sep 9, 2015 · 8 comments
Closed

TypeScript branch #161

ctoran opened this issue Sep 9, 2015 · 8 comments

Comments

@ctoran
Copy link

ctoran commented Sep 9, 2015

I forked the Aurelia skeleton-navigation, created a new master-typescript branch from it, then merged in the TypeScript version of the app from jdanyow/aurelia-typescript-skeleton and brought it up to date with the latest in the master.

You can find the changes here: https://github.com/ctoran/skeleton-navigation/tree/master-typescript

I wanted to make a pull request but I don't want it to go to the master branch. My request is, while the build process for ES6 and TypeScript are not unified, let's at least keep them in parallel branches in the same repository. This makes it much easier to compare branches and keep them in sync.

I also suggest we do the same for other samples like app-contacts.

I've already signed your CLA, if you create a master-typescript branch, I will make a pull request to that.

Thanks.

@ctoran
Copy link
Author

ctoran commented Sep 11, 2015

I also added all typings, so now with the TypeScript compiler option of noImplicitAny: true it compiles all with no errors. Right now this is the cleanest port of skeleton-navigation to TS out there. Please let me know if you are interested in this stuff.

@EisenbergEffect
Copy link
Contributor

We are going to deprecate this skeleton for v1 in place of a new, easier way to start projects. I wouldn't spend a lot of time on this. The new getting started infrastructure will let you select what options you want, including TypeScript.

@ctoran
Copy link
Author

ctoran commented Sep 13, 2015

That would be great! Thanks.

@akauppi
Copy link
Contributor

akauppi commented Sep 13, 2015

Wonderful!

This sounds like a good way to go. The modularity I see in Aurelia is one of the factors why I keep an eye on it.

@vip32
Copy link

vip32 commented Nov 24, 2015

@EisenbergEffect Can you give some details about this 'getting started infrastructure'? i want to start with the beta1 skeleton but typescript is not in there. The 'generator-aurelia' doesn't provide the typescript option.

@zewa666
Copy link
Member

zewa666 commented Nov 25, 2015

@vip32 the mentioned getting started packages are found here http://aurelia.io/docs.html#/aurelia/framework/1.0.0-beta.1.0.2/doc/article/getting-started

I will update the yeoman generator to include those as well

@vip32
Copy link

vip32 commented Nov 25, 2015

yes, those I have found. that is great starting material. but was more looking for the whole TS skeleton including the gulp tasks for TS

@vip32
Copy link

vip32 commented Nov 26, 2015

found this: https://github.com/eriklieben/skeleton-navigation-typescript
seems like it is a port of the skeleton-navigation to typescript with also the gulp stuff updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants