Skip to content

Commit d74f117

Browse files
committed
Update password_reminder.php
This is to prevent the logic vulnerability, pretty serious bug tbh. The $_SESSION array gets re-written between setting and checking and so your logic fails and an attacker can update anyones password...
1 parent e2cc51d commit d74f117

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

password_reminder.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@
9696

9797
if ($_REQUEST['h'] != $hash_bit) {
9898
$msg->addError('INVALID_LINK');
99-
$savant->display('password_reminder_feedback.tmpl.php');
10099
} else if (($_REQUEST['h'] == $hash_bit) && !isset($_POST['form_change'])) {
101100
$savant->assign('id', $_REQUEST['id']);
102101
$savant->assign('g', $_REQUEST['g']);
@@ -178,4 +177,4 @@
178177
}
179178

180179

181-
?>
180+
?>

0 commit comments

Comments
 (0)