Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Seems to be printing the TUI to the main shell, hiding previous shell output #2522

Closed
1 task done
FlynnD273 opened this issue Jan 4, 2025 · 4 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@FlynnD273
Copy link

What did you expect to happen?

Atuin seems to be printing the TUI to the main shell window instead of a separate one. I think this is relatively new behaviour. I've tested it on both Bash and Zsh with the same issue on both. I'm fairly certain it happened after the most recent update, but I'm not entirely sure. I'd expect the shell to look like this after I close the Atuin history window:

~ ❱ echo hi there
hi there
~ ❱

What happened?

But the shell output actually looks like this:

~ ❱ echo hi there
hi there

~ ❱

<Many blank lines>

  > 3ms    2s ago echo hi there
 [   SESSION    ]
 echo hi there

~ ❱

Atuin doctor output

Atuin Doctor
Checking for diagnostics


Please include the output below with any bug reports or issues

{
  "atuin": {
    "version": "18.4.0",
    "sync": null,
    "sqlite_version": "3.46.0"
  },
  "shell": {
    "name": "zsh",
    "default": "zsh",
    "plugins": [
      "atuin"
    ],
    "preexec": "built-in"
  },
  "system": {
    "os": "Arch Linux",
    "arch": "x86_64",
    "version": "rolling",
    "disks": [
      {
        "name": "/dev/nvme0n1p2",
        "filesystem": "ext4"
      },
      {
        "name": "systemd-1",
        "filesystem": "autofs"
      },
      {
        "name": "/dev/nvme0n1p1",
        "filesystem": "vfat"
      }
    ]
  }
}

Code of Conduct

  • I agree to follow this project's Code of Conduct
@FlynnD273 FlynnD273 added the bug Something isn't working label Jan 4, 2025
@johnkalish
Copy link

I just started seeing this today after upgrading to 18.4 from 18.2.

@johnkalish
Copy link

looks like it was introduced post-18.3; i just downgraded to that and output looks great to me

@johnkalish
Copy link

narrowed it down to in between 18.4.0 beta 3 and beta 5

@ellie
Copy link
Member

ellie commented Jan 7, 2025

Hey! This is intentional - see #2249 for discussion. I tried to call it out and provide as much space as possible for discussion. It's also referenced in the release notes

You can set inline_height = 0 for the old, alt-screen behaviour.

@ellie ellie closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants