Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

erb support ? (for rails integration) #64

Open
renatodeleao opened this issue Oct 15, 2019 · 0 comments
Open

erb support ? (for rails integration) #64

renatodeleao opened this issue Oct 15, 2019 · 0 comments

Comments

@renatodeleao
Copy link

Hi! I'm using mjml-rails to build the html emails for a Rails application.

The highlighter works great but it throws errors when using erb to call helpers inside the values. This expected because there's of the typechecking going on.

<%# type error: color value is not of the type "color" %>
<mj-attributes>
  <mj-text color="<%= helper["grayscale"]["500"] %>" />
</mj-attributes>

Initializing constants

<%# element % doesn't exist or is not registered %>
<%
  constant = "value"
%>

<mjml>
...
<mjml>
...

So this is not a bug report, but more of question: do you intend to support mjml.erb files? Having your document all red underlined is kind of confusing.

Thanks for work on this nonetheless! ☮️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant