Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

icons don't show in VS Code #57

Open
GarryFlemings opened this issue Mar 8, 2019 · 0 comments
Open

icons don't show in VS Code #57

GarryFlemings opened this issue Mar 8, 2019 · 0 comments

Comments

@GarryFlemings
Copy link

Before you open an issue, please check if a similar issue already exists or has been closed before.
Didn't see one.

Condition

I copied the MJML documentation code for mj-accordian to https://mjml.io/try-it-live/S1dk7Ikw4 and to VS Code.

Expected behavior

Please provide a description of the behavior you expect.

image

This is from Try-It-Live. The icons show. This result occurs with the MJML app, too. Also when I point Chrome or Firefox to the HTML file.

Actual behavior

Please provide a description of the actual behavior you observe.

image 1

This is from VS Code. The icons do not show.

Steps to reproduce the problem

Asked for help on MJML channel. https://mjml.slack.com/archives/C12HESC2G/p1552024785161900 (that link could fail to work within a couple weeks or so). Final answer: shoulder shrug. Me, too!

Code sample

Please provide a code snippet.

https://mjml.io/try-it-live/S1dk7Ikw4
and

  <mj-head>
    <mj-attributes>
      <mj-accordion border="none" padding="1px" />
      <mj-accordion-element icon-wrapped-url="http://i.imgur.com/Xvw0vjq.png" icon-unwrapped-url="http://i.imgur.com/KKHenWa.png" icon-height="24px" icon-width="24px" />
      <mj-accordion-title font-family="Roboto, Open Sans, Helvetica, Arial, sans-serif" background-color="#fff" color="#031017" padding="15px" font-size="18px" />
      <mj-accordion-text font-family="Open Sans, Helvetica, Arial, sans-serif" background-color="#fafafa" padding="15px" color="#505050" font-size="14px" />
    </mj-attributes>
  </mj-head>

  <mj-body>
    <mj-section padding="20px" background-color="#ffffff">
      <mj-column background-color="#dededd">
        <mj-accordion>
          <mj-accordion-element>
            <mj-accordion-title>Why use an accordion?</mj-accordion-title>
            <mj-accordion-text>
              <span style="line-height:20px">
                Because emails with a lot of content are most of the time a very bad experience on mobile, mj-accordion comes handy when you want to deliver a lot of information in a concise way.
              </span>
            </mj-accordion-text>
          </mj-accordion-element>
          <mj-accordion-element>
            <mj-accordion-title>How it works</mj-accordion-title>
            <mj-accordion-text>
              <span style="line-height:20px">
                Content is stacked into tabs and users can expand them at will. If responsive styles are not supported (mostly on desktop clients), tabs are then expanded and your content is readable at once.
              </span>
            </mj-accordion-text>
          </mj-accordion-element>
        </mj-accordion>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

Screenshot / GIF

See above.

Specifications

  • VS Code version: 1.32.1
  • MJML extension version: 1.6.0
  • Operating system and version: Win10 Home, Version 1803, OS Build 17134.619. Windows Update reports "Up to date" "Last checked:" about an hour ago.

Other information

List any other information that is relevant to your issue.

I'll check back, in case you need more info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant