Avoid complaints during startup, add Unsupported #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a program using this library doesn't have clipboard manipulation as its main feature (just a useful extra), this library always complaining to stderr during init, where it can't be stopped, makes those programs verbose during startup on systems where there is no clipboard (eg, headless servers). Rather than complain to stdio in a library, move the complaint into an error return to make it clearer what's going wrong. In addition, export a package variable `Unsupported` which client programs might use to inhibit use of the clipboard functions, for smoother integration.
|
Thank you for your pull request! LGTM |
atotto
added a commit
that referenced
this pull request
Oct 24, 2015
Avoid complaints during startup, add Unsupported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a program using this library doesn't have clipboard manipulation as
its main feature (just a useful extra), this library always complaining
to stderr during init, where it can't be stopped, makes those programs
verbose during startup on systems where there is no clipboard (eg,
headless servers).
Rather than complain to stdio in a library, move the complaint into an
error return to make it clearer what's going wrong.
In addition, export a package variable
Unsupportedwhich clientprograms might use to inhibit use of the clipboard functions, for
smoother integration.