Skip to content
This repository has been archived by the owner on Apr 6, 2018. It is now read-only.

Scroll window up/down fails sporadically #941

Closed
dcalhoun opened this issue Dec 21, 2015 · 9 comments
Closed

Scroll window up/down fails sporadically #941

dcalhoun opened this issue Dec 21, 2015 · 9 comments
Labels

Comments

@dcalhoun
Copy link
Contributor

The scroll window up/down commands no longer work consistently.

Behavior

As a user, I press and hold ctrl + e or ctrl + y.

Expected Outcome

They editor moves up or down by a single (1) line for as long as I hold the keys, until reaching the end of the document.

Current Outcome

The editor:

  • Moves a single line, then halts.
  • Does nothing for a few seconds, then begins scrolling as expected.
  • Scrolls the document, but displays artifacts frozen in place.

Environment

  • Mac OS X 10.11.2 (15C50)
  • Atom v1.3.2
  • vim-mode v0.64.0
  • Various different files types (e.g. – .html.erb, .scss, .js)

cc/ @maxbrunsfeld – possibly related to your changes in #938. This seemed to start with v0.64.0.

@gittyupagain
Copy link
Contributor

Scrolling feedback is only shown in the main window when the cursor is on the 3rd or 4th line from the top (with ctrl + e) or bottom (with ctrl + y). When the problem is happening, the proper view isn't updated until another key is pressed, or the cursor reaches the 3rd or 4th line. The minimap window properly shows what should be shown in the main window, regardless of cursor position.

@winstliu winstliu added the bug label Jan 7, 2016
@dcalhoun
Copy link
Contributor Author

This bug appears to affect all scroll commands (e.g. – half page down, page down).

If you use ctrl + f to scroll to the bottom of the document, you end up a few lines (~10) above the bottom with the cursor off the screen. After reaching the bottom of the document, if you press k, the window jumps to reveal the bottom of the document and the cursor.

@maxbrunsfeld
Copy link
Contributor

@dcalhoun @gittyupagain Sorry for the poor experience continuing. I can't reproduce this on my master build of Atom, I'm wondering if it was fixed by either atom/atom#9444 or atom/atom#10062.

If you're interested, could you try Atom v1.4.0-beta3? The first PR mentioned above is included in that release. If that doesn't help, I believe the fix may be on master, and we're going to release new beta and stable versions by Wednesday.

@gittyupagain
Copy link
Contributor

I just tried Atom v1.4.0-beta3, and I still see the ctrl+e / ctrl+y problem. I don't see the problem with ctrl+f that @dcalhoun is seeing, but I didn't see that with Atom v1.3.3 either.

Trying to isolate the problem, I removed my ~/.atom directory. After relaunching and installing just vim-mode, I still see the problem with Atom v1.4.0-beta3.

@dcalhoun
Copy link
Contributor Author

I never tried Atom v1.4.0-beta, but this bug is definitely still a problem in the v1.4.0 release.

@dragonxlwang
Copy link

yes, it is still a bug in v1.4.1. Hope it could get fixed soon.

@narychen
Copy link

+1

@dcalhoun
Copy link
Contributor Author

dcalhoun commented Feb 2, 2016

Both issues appear to be resolved in Atom v1.4.2.

@dcalhoun dcalhoun closed this as completed Feb 2, 2016
@maxbrunsfeld
Copy link
Contributor

Really sorry for the wait on this one @dcalhoun. I thought I had back-ported the fix to an earlier release 😬.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants