-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to activate the tool-bar package #96
Comments
Hi @urzds this seems to be connected to Nuclide. Could you try to upgrade it to 0.111.0 and see if it helps? |
@suda: Hello! Yes, by now the error message does not appear anymore. |
Great! Thanks for checking this :) |
0.111.0 of nuclide didn't help for latest update 0.1.11 Atom Version: 1.4.0 Stack TraceFailed to activate the tool-bar package
Commands
Config{
"core": {
"destroyEmptyPanes": false,
"disabledPackages": [
"deprecation-cop",
"fuzzy-finder",
"metrics",
"styleguide",
"timecop",
"pane-manager",
"tree-view"
],
"themes": [
"atom-material-ui",
"material-syntax"
]
},
"tool-bar": {
"iconSize": "16px",
"position": "Right"
}
} Installed Packages# User
atom-material-ui, v0.8.0
docblockr, v0.7.3
emmet, v2.4.0
file-icons, v1.6.14
haskell-grammar, v0.4.0
highlight-selected, v0.11.1
language-babel, v2.11.3
language-ini, v1.14.0
language-ocaml, v1.1.2
language-svg, v0.9.0
language-thrift, v1.0.2
material-syntax, v0.5.0
minimap, v4.19.0
nuclide, v0.111.20207720-1
tool-bar, v0.1.11
# Dev
No dev packages |
Does Nuclide provide two toolbar or alters it standard ToolBar buttons? |
@jerone I work on nuclide. On both our internal and external releases (for those facebookers reading this) only use one toolbar. However, some features, like the I have noticed that since the toolbar doesn't provide a mechanism to notify consumers when the How do you feel about the |
You mean that when the Tool Bar package is disabled, the reference to the button added by your package is still alive? We're always open for an PR. |
#101 fixes this issue and provides a way for consumers to be notified when the Tool Bar package is destroyed. |
Saw this upgrading to 0.2.0 but I guess I won't see it again? |
It shouldn't be happening again if you install latest version. |
This has returned as of Atom v1.16 |
@jerone this is back in Atom 1.16.beta0
|
@jerone Me too! 😢
|
I just published [email protected] that fixes the Atom 1.16.0 issue |
@zertosh the update just broke tool-bar in my Atom 1.15.0
|
@forestgagnon looking into it |
@forestgagnon here's the fix cakecatz/flex-toolbar#98 |
How do I update to that revision? Will you be pushing a revision that makes sure this doesn't happen in the release versions? |
@forestgagnon I merged @zertosh 's PR and published [email protected] 😎 |
Thanks, works like a charm now! |
Awesome thanks! |
[Enter steps to reproduce below:]
Atom Version: 1.2.4
System: Ubuntu 14.04.3
Thrown From: tool-bar package, v0.1.10
Stack Trace
Failed to activate the tool-bar package
Commands
Config
Installed Packages
The text was updated successfully, but these errors were encountered: