Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Restore node_modules caches in sync with one-another. #104

Closed
DeeDeeG opened this issue Aug 23, 2020 · 1 comment
Closed

CI: Restore node_modules caches in sync with one-another. #104

DeeDeeG opened this issue Aug 23, 2020 · 1 comment
Labels

Comments

@DeeDeeG
Copy link
Member

DeeDeeG commented Aug 23, 2020

We can set the key for caches to include all three sets of package.json and package-lock.json.

That way, either no caches will hit, or all caches will hit.

Should save our sanity trying to debug partial cache restores.

This is also a performance optimization, as it will save us from spending the time doing partial restores, which then immediately get wiped by npm ci during bootstrap.


I want to stress that, given the current state of master, this is a no-downsides fix. I want to do this for master.

We can keep investigating #33 in spare time. I don't support the initial premise of that PR, but I'm willing to be proved wrong on that, which is why I'd still try to think if there are ways it could work. And obviously other things are a higher priority. This issue is for a simple correctness fix and performance improvement and should not be controversial to do while #33 remains an experiment. The merge conflicts from doing this would be trivially easy to fix and I volunteer to do them myself.

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Aug 23, 2020

WIP branch: master...DeeDeeG:CI-synced-caches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants