Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification won't dealloc unless #38

Open
MobileMon opened this issue Feb 19, 2018 · 2 comments
Open

Notification won't dealloc unless #38

MobileMon opened this issue Feb 19, 2018 · 2 comments
Assignees

Comments

@MobileMon
Copy link

The view won't dealloc unless I manually remove it from superView in the didDismissDelegateMethod

The problem with this though is if minimalNotificationDidDismissNotification method is never called, then the view is never dismissed. It may never get called if the view controller that called it is no longer alive, like popping back from a detail view controller

You can actually still see the view when rotating portrait to landscape on iphone x

  • (void)minimalNotificationDidDismissNotification:(JFMinimalNotification*)notification {
    NSLog(@"didDismissNotification");
    if (notification != nil){
    [notification removeFromSuperview];
    }
    }
@atljeremy
Copy link
Owner

Well that's not good. I'll dig into this issue tonight and get something pushed up to address it. In the meantime, could you put together a simple project that demonstrates the issue and share it with me? That'll save some time in trying to reproduce the issue. Thanks!

@atljeremy atljeremy self-assigned this Feb 19, 2018
@MobileMon
Copy link
Author

I forked the project to demonstrate the issue. Use the example project:
https://github.com/MobileMon/JFMinimalNotifications

In JFMinimalNotification.m I added a NSLog statement when dealloc is called

Now push and pop from both buttons and notice dealloc is not called when I don't remove from superview

Also goto either detail screen and let the notification appear. Now rotate the device landscape and see that the notification is actually still there (its just out of view) meaning it never actually removed itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants