Skip to content

Commit 674b442

Browse files
Merge pull request #137 from atlanhq/revert-131-DQ-384-contract-impact-analysis
Revert "DQ-384 feat(contract): add support for contract impact analysis"
2 parents 016787c + 35ba0c7 commit 674b442

16 files changed

+625
-7056
lines changed

.github/workflows/test-action.yml

-3
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ name: Test Action
33
on:
44
pull_request:
55
types: [opened, edited, synchronize, reopened, closed]
6-
paths:
7-
- 'test/**'
86

97
jobs:
108
get-downstream-assets:
@@ -31,4 +29,3 @@ jobs:
3129
beta: Wide World Importers PE1
3230
test-action: Wide World Importers PE1
3331
IGNORE_MODEL_ALIAS_MATCHING: true
34-
ATLAN_CONFIG: .atlan/config.yaml

.gitignore

+1-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,4 @@
44
node_modules/
55
event.json
66
.idea
7-
.DS_Store
8-
.vscode/
9-
contracts/
10-
.atlan/
7+
.DS_Store

README.md

-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ After you've completed the configuration above, create a pull request with a cha
6868
| `ATLAN_API_TOKEN` | Needed for authenticating API requests to the user's tenant. https://ask.atlan.com/hc/en-us/articles/8312649180049 | true |
6969
| `DBT_ENVIRONMENT_BRANCH_MAP` | Map Github branch with specific dbt environment, if you do this - Atlan Github action will pick lineage for that specific environment from Atlan.You can provide the mapping like `branch name`: `dbt environment name`. <br><br>main: DBT-DEMO-PROD<br>beta: Wide World Importers PE1<br>test-action: Wide World Importers PE1 | false |
7070
| `IGNORE_MODEL_ALIAS_MATCHING` | By default the action checks if there's an alias defined for a model in the code and looks for the relevant asset in Atlan using that alias. You can turn off matching alias name using this variable. | false | false |
71-
| `ATLAN_CONFIG` | The Atlan CLI configuration file is typically located at `.atlan/config.yaml`. Setting the `ATLAN_CONFIG` environment variable will trigger impact analysis on Atlan Data Contracts, if included in a GitHub pull request. | false | |
7271

7372
## FAQs
7473

action.yml

-3
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ inputs:
1919
description: "Ignore model alias matching"
2020
required: false
2121
default: false
22-
ATLAN_CONFIG:
23-
description: "Atlan CLI config file location"
24-
required: false
2522
runs:
2623
using: "node16"
2724
main: "dist/index.js"

adapters/api/get-asset-classifications.js

-33
This file was deleted.

adapters/api/get-classifications.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1+
import fetch from "node-fetch";
12
import {
2-
ATLAN_API_TOKEN,
33
ATLAN_INSTANCE_URL,
4+
ATLAN_API_TOKEN,
45
} from "../utils/get-environment-variables.js";
56

6-
import fetch from "node-fetch";
7-
87
export default async function getClassifications({
98
sendSegmentEventOfIntegration,
109
}) {
@@ -35,4 +34,4 @@ export default async function getClassifications({
3534
});
3635

3736
return response?.classificationDefs;
38-
}
37+
}

adapters/api/get-contract-asset.js

-102
This file was deleted.

0 commit comments

Comments
 (0)