Merge pull request #1109 from atlanhq/FT-859

Improves logging on any CSV decoding errors

Author: cmgrote

package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/cell/CellXformer.kt

@@ -101,7 +101,7 @@ object CellXformer {
             when (type) {
                 Collection::class.java, List::class.java -> list
                 Set::class.java, SortedSet::class.java -> TreeSet(list)
-                else -> throw IOException("Unable to deserialize cell to Java class: $type")
+                else -> throw IOException("Unable to deserialize cell to Java class (in $fieldName): $type")
             }
         } else if (Map::class.java.isAssignableFrom(type)) {
             TODO("Not yet implemented for import")
@@ -118,7 +118,7 @@ object CellXformer {
             // there should be asset references
             AssetRefXformer.decode(ctx, value, fieldName)
         } else {
-            throw IOException("Unhandled data type for $fieldName: $type")
+            throw IOException("Unhandled data type (in $fieldName): $type")
         }
     }
 

package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/cell/ConnectionXformer.kt

@@ -66,7 +66,7 @@ object ConnectionXformer {
         return when (fieldName) {
             "connection" -> {
                 ctx.connectionCache.getByIdentity(assetRef)
-                    ?: throw NoSuchElementException("Connection $assetRef not found.")
+                    ?: throw NoSuchElementException("Connection $assetRef not found (in $fieldName).")
             }
             else -> AssetRefXformer.decode(ctx, assetRef, fieldName)
         }

package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/cell/DataDomainXformer.kt

@@ -54,7 +54,7 @@ object DataDomainXformer {
         return when (fieldName) {
             DataDomain.PARENT_DOMAIN.atlanFieldName, DataProduct.DATA_DOMAIN.atlanFieldName -> {
                 ctx.dataDomainCache.getByIdentity(assetRef)?.trimToReference()
-                    ?: throw NoSuchElementException("Domain $assetRef not found.")
+                    ?: throw NoSuchElementException("Domain $assetRef not found (in $fieldName).")
             }
             else -> AssetRefXformer.decode(ctx, assetRef, fieldName)
         }

package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/cell/GlossaryCategoryXformer.kt

@@ -53,11 +53,11 @@ object GlossaryCategoryXformer {
         return when (fieldName) {
             GlossaryCategory.PARENT_CATEGORY.atlanFieldName -> {
                 ctx.categoryCache.getByIdentity(assetRef)?.trimToReference()
-                    ?: throw NoSuchElementException("Parent category $assetRef not found.")
+                    ?: throw NoSuchElementException("Parent category $assetRef not found (in $fieldName).")
             }
             GlossaryTerm.CATEGORIES.atlanFieldName -> {
                 ctx.categoryCache.getByIdentity(assetRef)?.trimToReference()
-                    ?: throw NoSuchElementException("Category relationship $assetRef not found.")
+                    ?: throw NoSuchElementException("Category relationship $assetRef not found (in $fieldName).")
             }
             else -> AssetRefXformer.decode(ctx, assetRef, fieldName)
         }

package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/cell/GlossaryTermXformer.kt

@@ -70,7 +70,7 @@ object GlossaryTermXformer {
             "assignedTerms", in TERM_TO_TERM_FIELDS,
             ->
                 ctx.termCache.getByIdentity(assetRef)?.trimToReference()
-                    ?: throw NoSuchElementException("Term $assetRef not found (via $fieldName).")
+                    ?: throw NoSuchElementException("Term $assetRef not found (in $fieldName).")
             else -> AssetRefXformer.decode(ctx, assetRef, fieldName)
         }
     }

package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/cell/GlossaryXformer.kt

@@ -53,7 +53,7 @@ object GlossaryXformer {
         return when (fieldName) {
             GlossaryTerm.ANCHOR.atlanFieldName -> {
                 ctx.glossaryCache.getByIdentity(assetRef)?.trimToReference()
-                    ?: throw NoSuchElementException("Parent glossary $assetRef not found.")
+                    ?: throw NoSuchElementException("Parent glossary $assetRef not found (in $fieldName).")
             }
             else -> AssetRefXformer.decode(ctx, assetRef, fieldName)
         }

package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/cell/GroupXformer.kt

@@ -53,7 +53,7 @@ object GroupXformer {
                         // And if found by alias, return the group name (since that's what we require)
                         return client.groupCache.getNameForId(idFromAlias)
                     } catch (e: NotFoundException) {
-                        throw NoSuchElementException("Group name / alias $groupRef is not known to Atlan.", e)
+                        throw NoSuchElementException("Group name / alias $groupRef is not known to Atlan (in $fieldName).", e)
                     }
                 }
             }

package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/cell/ModelAssetXformer.kt

@@ -93,7 +93,7 @@ object ModelAssetXformer {
                         .semantic(Reference.SaveSemantic.APPEND)
                         .build()
                 } else {
-                    throw NoSuchElementException("Model asset $assetRef not found (via $fieldName).")
+                    throw NoSuchElementException("Model asset $assetRef not found (in $fieldName).")
                 }
             }
             in MODEL_ASSET_REF_FIELDS -> {
@@ -102,7 +102,7 @@ object ModelAssetXformer {
                         .semantic(Reference.SaveSemantic.REPLACE)
                         .build()
                 } else {
-                    throw NoSuchElementException("Model asset $assetRef not found (via $fieldName).")
+                    throw NoSuchElementException("Model asset $assetRef not found (in $fieldName).")
                 }
             }
             else -> AssetRefXformer.decode(ctx, assetRef, fieldName)

package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/cell/RoleXformer.kt

@@ -44,7 +44,7 @@ object RoleXformer {
                     // Try to look up the user reference by username
                     return client.roleCache.getIdForName(roleRef)
                 } catch (e: NotFoundException) {
-                    throw NoSuchElementException("Role name $roleRef is not known to Atlan.", e)
+                    throw NoSuchElementException("Role name $roleRef is not known to Atlan (in $fieldName).", e)
                 }
             }
             else -> roleRef

package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/cell/UserXformer.kt

@@ -55,7 +55,7 @@ object UserXformer {
                         // And if found by email, return the username (since that's what we require)
                         return client.userCache.getNameForId(idFromEmail)
                     } catch (e: NotFoundException) {
-                        throw NoSuchElementException("Username / email address $userRef is not known to Atlan.", e)
+                        throw NoSuchElementException("Username / email address $userRef is not known to Atlan (in $fieldName).", e)
                     }
                 }
             }