feat(nav): nav support responsive #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why520crazy
requested changes
May 28, 2021
src/nav/nav.component.ts
Outdated
|
|
||
| public moreActive: boolean; | ||
|
|
||
| @ContentChildren(ThyNavLinkDirective, { descendants: true }) tabs: QueryList<ThyNavLinkDirective>; |
There was a problem hiding this comment.
这个 tabs 改一个名字，叫 links 或者 navLinks
src/nav/nav.component.ts
Outdated
Comment on lines
150
to
152
| this.ngZone.onStable.pipe(takeUntil(this.ngUnsubscribe$)).subscribe(() => { | ||
| this.calculateMoreIsActive(); | ||
| }); |
There was a problem hiding this comment.
这个地方订阅计算更多是否激活是不是太频繁了，使用 ngAfterContentChecked 或者 ngAfterViewChecked 钩子中检查可以吗？
src/nav/nav-link.directive.ts
Outdated
Comment on lines
60
to
64
| this.width = this.elementRef.nativeElement.offsetWidth; | ||
| this.height = this.elementRef.nativeElement.offsetHeight; | ||
| this.left = this.elementRef.nativeElement.offsetLeft; | ||
| this.top = this.elementRef.nativeElement.offsetTop; | ||
| this.content = this.elementRef.nativeElement.outerHTML; |
There was a problem hiding this comment.
建议直接使用一个 offset 的 get 访问器返回 width，height，left，top 等数据，不要通过变量保存起来
why520crazy
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.