Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the imba version in use #8

Closed
aalemayhu opened this issue Sep 16, 2019 · 2 comments
Closed

Document the imba version in use #8

aalemayhu opened this issue Sep 16, 2019 · 2 comments

Comments

@aalemayhu
Copy link
Contributor

Hei,

I was looking at the pkg.js and it looks like you are not using the official Imba version for the parcel and a old Imba version for webpack. Why is that the case?

exports.parcelPkg = {
[...]
	dependencies: {
		'imba': 'github:pushqrdx/imba'
	},
[...]
	devDependencies: {
		'sass': '^1.16.1',
		'parcel-bundler': '^1.10.3',
		'parcel-plugin-imba': 'github:shreeve/parcel-plugin-imba'
	}
}

exports.webpackPkg = {
[...]
	dependencies: {
	    "imba": "1.4.1",
		"css-loader": "^1.0.1",
	    "extract-text-webpack-plugin": "^4.0.0-beta.0",
	    "normalize-scss": "^7.0.1",
	    "style-loader": "^0.23.1",
	    "webpack-dev-server": "^3.1.10"
	},
	devDependencies: {
		"node-sass": "^4.10.0",
	    "sass-loader": "^7.1.0",
	    "webpack": "^4.26.0",
	    "webpack-cli": "^3.1.2"
	}
}
@athif23
Copy link
Owner

athif23 commented Sep 16, 2019

Oh, I forgot to change. The case is, @pushqrdx imba repo, has some update that I think people would like to use, but I don't think that's needed right now. Thanks for telling me.

@athif23
Copy link
Owner

athif23 commented Sep 16, 2019

Just published the new version, I would close this now.

@athif23 athif23 closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants