-
-
Notifications
You must be signed in to change notification settings - Fork 993
chore: update tools.json #4117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update tools.json #4117
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThe changes involve reordering, updating, and correcting entries in three JSON configuration files related to technology tags and tool listings. Modifications include swapping positions of adjacent entries, inserting new entries, removing duplicates, updating metadata, and adjusting categorization for accuracy and consistency. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ConfigFiles
participant ToolListings
User->>ConfigFiles: Update tags and tool entries
ConfigFiles->>ToolListings: Reflect reordered, added, or removed entries
ToolListings-->>User: Provide updated tool/tag data for UI or processing
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4117 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
config/tools.json (1)
2643-2669: Differentiate the new HTML Template variant.
A secondHTML Templateentry (dipaksodani/async-gen) has been added with anulldescription and identical title/filters to the official template. Consider providing a meaningfuldescriptionto distinguish it in the UI (e.g., “Alternate HTML template by Dipak Sodani”) and avoid ambiguity.config/tools-automated.json (1)
943-959: Provide a description for the duplicated HTML Template.
In the automated config, a duplicateHTML Templateentry is added withdescription: null. Supplying a descriptive summary will improve clarity for end users and prevent the UI from displaying rawnull.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (3)
config/all-tags.json(2 hunks)config/tools-automated.json(13 hunks)config/tools.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (5)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
🔇 Additional comments (3)
config/all-tags.json (3)
271-279: Verify technology tag swap of SmartPaste and JetBrains.
The positions of theSmartPasteandJetBrainsentries have been swapped. Please confirm that this new order is intentional, aligns with the UI grouping expectations, and does not introduce duplicate or missing tags.
291-294: Add Java technology tag for proper tool categorization.
The newly introducedJavaentry withbg-[#61d0f2]andborder-[#40ccf7]looks correct. Ensure that all Java-based tools reference this new tag and that the color codes align with branding guidelines.
296-304: Rename original Java tag to HTML – check for duplicates.
The originalJavatag has been renamed toHTML, creating twoHTMLentries. Verify that no tool listings rely on the old Java key and that having duplicate HTML tags does not lead to confusion in filtering or rendering.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Improvements