From fbb1bedb105b28a40d758e2f3afd2bc8a08e43fe Mon Sep 17 00:00:00 2001 From: Ram Shukla Date: Mon, 10 Mar 2025 12:28:57 +0530 Subject: [PATCH 1/4] fix: remove Twitter link for ambassador without a Twitter account Fixes #3828 Remove the Twitter link for the ambassador without a Twitter account. * Update `config/AMBASSADORS_MEMBERS.json` to remove the `twitter` field for the ambassador without a Twitter account. * Modify `pages/community/ambassadors/index.tsx` to add a conditional check to only generate a Twitter URL if the ambassador has a Twitter account. * Update `pages/community/ambassadors/index.tsx` to add a conditional check to only display the Twitter link if the profile has a Twitter account. --- config/AMBASSADORS_MEMBERS.json | 1 - pages/community/ambassadors/index.tsx | 22 ++++++++++++---------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/config/AMBASSADORS_MEMBERS.json b/config/AMBASSADORS_MEMBERS.json index 6c84a5895ffc..4a1457764245 100644 --- a/config/AMBASSADORS_MEMBERS.json +++ b/config/AMBASSADORS_MEMBERS.json @@ -468,7 +468,6 @@ { "name": "Manuel Ottlik", "github": "manuelottlik", - "twitter": "", "linkedin": "manuelottlik", "country": "🇩🇪", "bio": "Manuel is the Product Owner of the Global Integration Platform at HDI Global SE. He sold his first software at the age of thirteen and has been developing software ever since. After graduating, he joined the financial industry in API management and eventually moved to HDI Global SE to merge a service bus, API management and an event broker into an integration platform for the cloud division. In addition to his work at HDI Global SE, he is co-founder of a small company in the education software sector and freelance writer for heise.de and its magazines.", diff --git a/pages/community/ambassadors/index.tsx b/pages/community/ambassadors/index.tsx index e707dc584c0c..bcb318ed129f 100644 --- a/pages/community/ambassadors/index.tsx +++ b/pages/community/ambassadors/index.tsx @@ -29,7 +29,7 @@ export function addAdditionalUserInfo(user: Ambassador) { userData.linkedinUrl = `https://www.linkedin.com/in/${userData.linkedin}`; } if (userData.twitter) { - userData.twitterUrl = `https://www.twitter.com/${userData.twitter}`; + userData.twitterUrl = userData.twitter ? `https://www.twitter.com/${userData.twitter}` : null; } // add img url @@ -141,15 +141,17 @@ export default function Index() {
{ambassador.bio}
- - Twitter ↗ - + {ambassador.twitterUrl && ( + + Twitter ↗ + + )} Github ↗ From 8daf646999f623783c0ace783a994112dfbf6ece Mon Sep 17 00:00:00 2001 From: Ram Shukla Date: Tue, 11 Mar 2025 12:02:48 +0530 Subject: [PATCH 2/4] --- config/AMBASSADORS_MEMBERS.json | 1 + 1 file changed, 1 insertion(+) diff --git a/config/AMBASSADORS_MEMBERS.json b/config/AMBASSADORS_MEMBERS.json index 4a1457764245..824f8a963e92 100644 --- a/config/AMBASSADORS_MEMBERS.json +++ b/config/AMBASSADORS_MEMBERS.json @@ -468,6 +468,7 @@ { "name": "Manuel Ottlik", "github": "manuelottlik", + "twitter": "ManuelOttlik", "linkedin": "manuelottlik", "country": "🇩🇪", "bio": "Manuel is the Product Owner of the Global Integration Platform at HDI Global SE. He sold his first software at the age of thirteen and has been developing software ever since. After graduating, he joined the financial industry in API management and eventually moved to HDI Global SE to merge a service bus, API management and an event broker into an integration platform for the cloud division. In addition to his work at HDI Global SE, he is co-founder of a small company in the education software sector and freelance writer for heise.de and its magazines.", From 7494a749297eeb4e0cbf44518a46f52cc1299b22 Mon Sep 17 00:00:00 2001 From: Ram Shukla Date: Tue, 11 Mar 2025 12:16:16 +0530 Subject: [PATCH 3/4] Update index.tsx --- pages/community/ambassadors/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/community/ambassadors/index.tsx b/pages/community/ambassadors/index.tsx index bcb318ed129f..43e5f38f6a8c 100644 --- a/pages/community/ambassadors/index.tsx +++ b/pages/community/ambassadors/index.tsx @@ -29,7 +29,7 @@ export function addAdditionalUserInfo(user: Ambassador) { userData.linkedinUrl = `https://www.linkedin.com/in/${userData.linkedin}`; } if (userData.twitter) { - userData.twitterUrl = userData.twitter ? `https://www.twitter.com/${userData.twitter}` : null; + userData.twitterUrl = `https://www.twitter.com/${userData.twitter}`; } // add img url From 18184eadd068f8e39f2b0ff8ee9d27f2a4275274 Mon Sep 17 00:00:00 2001 From: Ram Shukla Date: Tue, 11 Mar 2025 12:17:48 +0530 Subject: [PATCH 4/4] Update index.tsx --- pages/community/ambassadors/index.tsx | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/pages/community/ambassadors/index.tsx b/pages/community/ambassadors/index.tsx index 43e5f38f6a8c..e707dc584c0c 100644 --- a/pages/community/ambassadors/index.tsx +++ b/pages/community/ambassadors/index.tsx @@ -141,17 +141,15 @@ export default function Index() {
{ambassador.bio}