-
-
Notifications
You must be signed in to change notification settings - Fork 993
chore: update meetings.json and newsrooom_videos.json #3580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #3580
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughThe pull request involves updates to the Changes
Sequence DiagramsequenceDiagram
participant Dashboard
participant HotDiscussions
participant GoodFirstIssues
Dashboard->>HotDiscussions: Update entries
Dashboard->>HotDiscussions: Add new pull request
Dashboard->>GoodFirstIssues: Update existing issues
Dashboard->>GoodFirstIssues: Add new issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3580--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
dashboard.json (1)
316-325: Add appropriate labels and areas to improve issue discoverability.Two issues are missing labels and have "typescript" as their area:
- "Create Custom LogService Using Winston for Error Logging"
- "Optimize banner rendering performance to improve Lighthouse score"
Consider adding relevant labels like "enhancement" or "performance" to help contributors find these issues more easily.
Also applies to: 326-335
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
dashboard.json(5 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (2)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
🔇 Additional comments (2)
dashboard.json (2)
Line range hint
1-815: JSON structure looks good!The file maintains proper JSON formatting and includes all required fields consistently across entries.
43-43: Consider adjusting the scoring algorithm to avoid duplicate scores.Two entries have identical scores (22.112443333692923), which might affect proper ranking of discussions. Consider adding additional factors to the scoring algorithm to ensure unique scores.
Also applies to: 54-54
| "id": "I_kwDOBW5R_c6lGhu4", | ||
| "title": "[BUG] Community dropdown content not visible properly", | ||
| "isAssigned": false, | ||
| "resourcePath": "/asyncapi/website/issues/3509", | ||
| "resourcePath": "/asyncapi/website/issues/3549", | ||
| "repo": "asyncapi/website", | ||
| "author": "Pulkitxm", | ||
| "area": "javascript", | ||
| "labels": [] | ||
| "author": "rahulrana701", | ||
| "area": "Unknown", | ||
| "labels": [ | ||
| { | ||
| "name": "enhancement", | ||
| "color": "84b6eb" | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix inconsistent issue labeling.
The issue "[BUG] Community dropdown content not visible properly" is labeled as "enhancement" but appears to be a bug report based on its title. Consider updating the label to "bug" for consistency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3580 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 668 668
=========================================
Hits 668 668 ☔ View full report in Codecov by Sentry. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
Hot Discussions Updates
Good First Issues