Skip to content

fix: #3544 Misalignment of Height and Spacing in Case Study Block on Desktop and Mobile Views. #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 10, 2025
Merged

fix: #3544 Misalignment of Height and Spacing in Case Study Block on Desktop and Mobile Views. #3561

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2f8053
changed height and spacing issues
Sonalilipsa17375 Jan 10, 2025
869e249
fixed some failed test issues
Sonalilipsa17375 Jan 10, 2025
d779a39
fixed some failed test issues
Sonalilipsa17375 Jan 10, 2025
aadf0b8
fixed some failed test
Sonalilipsa17375 Jan 10, 2025
ee88cd3
fixed some failed test
Sonalilipsa17375 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions components/CaseStudyCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,12 @@ export default function CaseStudyCard({ studies = [] }: ICaseStudyCardProps) {
}

return (
<div className='flex flex-wrap pt-10 lg:grid lg:grid-cols-3 lg:gap-8 lg:text-center'>
<div className='flex flex-wrap pt-10 lg:grid lg:grid-cols-3 lg:gap-8 lg:text-center gap-3'>
{studies.map((study, index) => (
<a key={index} href={`casestudies/${study.id}`}>
<div
className='max-w-sm overflow-hidden rounded-md border border-gray-200 bg-white p-4'
data-testid='CaseStudyCard-main'
>
<div
className='max-w-sm h-full overflow-hidden min-h-[300px] rounded-md border border-gray-200 bg-white p-4'
data-testid='CaseStudyCard-main'>
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix formatting issues.

Address the following formatting issues:

  • Remove trailing spaces
  • Fix indentation
-          <div 
-          className='max-w-sm h-full overflow-hidden min-h-[300px] rounded-md border border-gray-200 bg-white p-4'
-          data-testid='CaseStudyCard-main'>
+          <div
+            className='max-w-sm h-full overflow-hidden min-h-[300px] rounded-md border border-gray-200 bg-white p-4'
+            data-testid='CaseStudyCard-main'
+          >
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<div
className='max-w-sm h-full overflow-hidden min-h-[300px] rounded-md border border-gray-200 bg-white p-4'
data-testid='CaseStudyCard-main'>
<div
className='max-w-sm h-full overflow-hidden min-h-[300px] rounded-md border border-gray-200 bg-white p-4'
data-testid='CaseStudyCard-main'
>
🧰 Tools
🪛 eslint

[error] 25-25: Trailing spaces not allowed.

(no-trailing-spaces)

[error] 25-26: Replace ·⏎ with ⏎··

(prettier/prettier)

[error] 27-27: Replace data-testid='CaseStudyCard-main' with ··data-testid='CaseStudyCard-main'⏎··········

(prettier/prettier)

🪛 GitHub Actions: PR testing - if Node project

[error] 25-25: Trailing spaces not allowed

[error] 25-25: Replace spaces with proper indentation

[warning] 26-26: Invalid Tailwind CSS classnames order

[error] 27-27: Incorrect indentation for data-testid attribute

<span className='mr-2'>
<img className='m-auto h-16' src={study.company.logo} alt={study.company.name} />
</span>
Expand Down
Loading