From 6de4171f2b63437040b548664b54a739d0db2550 Mon Sep 17 00:00:00 2001 From: Ansh Goyal Date: Wed, 23 Oct 2024 15:09:58 +0530 Subject: [PATCH 1/5] fix: restrict markdown tests to ubuntu runner --- .github/workflows/if-nodejs-pr-testing.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/if-nodejs-pr-testing.yml b/.github/workflows/if-nodejs-pr-testing.yml index c8c3bec4d3c7..51a60138df6e 100644 --- a/.github/workflows/if-nodejs-pr-testing.yml +++ b/.github/workflows/if-nodejs-pr-testing.yml @@ -2,7 +2,7 @@ name: PR testing - if Node project on: - pull_request: + pull_request_target: types: [opened, reopened, synchronize, ready_for_review] push: branches: [master] @@ -76,7 +76,7 @@ jobs: run: npm run generate:assets --if-present # Run the test:md script and capture output - - if: steps.packagejson.outputs.exists == 'true' + - if: ${{ steps.packagejson.outputs.exists == 'true' && matrix.os == 'ubuntu-latest' }} name: Run markdown checks id: markdown_check run: | @@ -87,7 +87,7 @@ jobs: # Post a comment using sticky-pull-request-comment - name: Comment on PR with markdown issues - if: ${{ steps.markdown_check.outputs.markdown_output != '' }} + if: ${{ steps.markdown_check.outputs.markdown_output != '' && matrix.os == 'ubuntu-latest' }} uses: marocchino/sticky-pull-request-comment@3d60a5b2dae89d44e0c6ddc69dd7536aec2071cd with: header: markdown-check-error @@ -102,7 +102,7 @@ jobs: ``` # Delete the comment if there are no issues - - if: ${{ steps.markdown_check.outputs.markdown_output == '' }} + - if: ${{ steps.markdown_check.outputs.markdown_output == '' && matrix.os == 'ubuntu-latest' }} name: Delete markdown check comment uses: marocchino/sticky-pull-request-comment@3d60a5b2dae89d44e0c6ddc69dd7536aec2071cd with: From 9725523b1166fb76f76108b2706690f9e70d54b1 Mon Sep 17 00:00:00 2001 From: Ansh Goyal Date: Wed, 23 Oct 2024 15:27:01 +0530 Subject: [PATCH 2/5] empty commit From 5f1935a0379fea2f50dbfe2fb654f22bc008a60e Mon Sep 17 00:00:00 2001 From: Ansh Goyal Date: Wed, 23 Oct 2024 16:24:46 +0530 Subject: [PATCH 3/5] remove target --- .github/workflows/if-nodejs-pr-testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/if-nodejs-pr-testing.yml b/.github/workflows/if-nodejs-pr-testing.yml index 51a60138df6e..10245191bafb 100644 --- a/.github/workflows/if-nodejs-pr-testing.yml +++ b/.github/workflows/if-nodejs-pr-testing.yml @@ -2,7 +2,7 @@ name: PR testing - if Node project on: - pull_request_target: + pull_request: types: [opened, reopened, synchronize, ready_for_review] push: branches: [master] From 6b18951621fb2299941bf1081cb630ce103b8b66 Mon Sep 17 00:00:00 2001 From: Ansh Goyal Date: Wed, 23 Oct 2024 16:25:22 +0530 Subject: [PATCH 4/5] add target --- .github/workflows/if-nodejs-pr-testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/if-nodejs-pr-testing.yml b/.github/workflows/if-nodejs-pr-testing.yml index 10245191bafb..51a60138df6e 100644 --- a/.github/workflows/if-nodejs-pr-testing.yml +++ b/.github/workflows/if-nodejs-pr-testing.yml @@ -2,7 +2,7 @@ name: PR testing - if Node project on: - pull_request: + pull_request_target: types: [opened, reopened, synchronize, ready_for_review] push: branches: [master] From 04a279f4b81fdbb13a30fce530b4ab09a34b92ea Mon Sep 17 00:00:00 2001 From: Ansh Goyal Date: Wed, 23 Oct 2024 17:31:51 +0530 Subject: [PATCH 5/5] add ref for checkout --- .github/workflows/if-nodejs-pr-testing.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/if-nodejs-pr-testing.yml b/.github/workflows/if-nodejs-pr-testing.yml index 51a60138df6e..a0fb664221c5 100644 --- a/.github/workflows/if-nodejs-pr-testing.yml +++ b/.github/workflows/if-nodejs-pr-testing.yml @@ -42,6 +42,9 @@ jobs: - if: steps.should_run.outputs.shouldrun == 'true' name: Checkout repository uses: actions/checkout@v4 + with: + ref: refs/pull/${{ github.event.pull_request.number }}/merge + - if: steps.should_run.outputs.shouldrun == 'true' name: Check if Node.js project and has package.json id: packagejson