Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radix-ui usage need an ADR #734

Closed
Amzani opened this issue Jul 11, 2023 · 2 comments · Fixed by #741
Closed

Radix-ui usage need an ADR #734

Amzani opened this issue Jul 11, 2023 · 2 comments · Fixed by #741
Labels
kind/adr create a new architectural decision record.

Comments

@Amzani
Copy link
Collaborator

Amzani commented Jul 11, 2023

Related to #678

cc @fmvilas

@Amzani Amzani added the enhancement New feature or request label Jul 11, 2023
@Amzani Amzani added kind/adr create a new architectural decision record. and removed enhancement New feature or request labels Jul 11, 2023
@Amzani
Copy link
Collaborator Author

Amzani commented Jul 13, 2023

@fmvilas why did we choose Radix-UI ?, I can help write this ADR.

@fmvilas
Copy link
Member

fmvilas commented Jul 13, 2023

Libraries like Radix or Headless UI have no implicit design. They're a set of components handling the logical part of them, not the design part. For instance, handling keyboard navigation, support for screen readers, checking if a menu has space to be rendered on the right and avoiding collisions with the limits of the window, etc.

We need to build our set of components, our own UI library. If we use a ready-made library of components, we would be stuck to this library look and feel. Also, we would not have much freedom since the design is part of the library and their components have it integrated, often making it difficult or impossible to change it.

I evaluated Radix and Headless UI. Chose Radix because it's more complete, well maintained, and its community is more active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/adr create a new architectural decision record.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants