-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Change the name of the generated model class withe name of message name. #1996
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
Makes sense, taget |
I just stumbled over this. I ran
I would've expected that the file name as well as the class name do use the actual name of the component / message / whatevs. Is there currently no way or do I have to set some extra annotation somewhere? |
Happy to accept and help guide a PR 🙂 Otherwise, yes, explicit annotations is the workaround |
What annotation would that be? |
This would be a breaking change, right? Any idea where to start? I imagined this to be an easy change but grepping for |
You would have to explicitly define the message payload as the name of the message.
Yes, just target the
All this logic happens in the input processor for AsyncAPI:
|
Why do we need this improvement?
Asyncapi.yml:
Output:
How will this change help?
This change will help to adhere proper naming of the project, lets suppose if we want to call the model class we need to call the AnonymousSchema_1 which seems to be not valid.
Screenshots
No response
How could it be implemented/designed?
🚧 Breaking changes
No
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered: