Fix schedule args for Airflow 3#413
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
- Coverage 95.04% 94.85% -0.20%
==========================================
Files 11 11
Lines 949 1011 +62
==========================================
+ Hits 902 959 +57
- Misses 47 52 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jlaneve
reviewed
Jun 5, 2025
pankajastro
force-pushed
the
fix_schedule
branch
from
c07dafa to
1d67379
Compare
pankajastro
force-pushed
the
fix_schedule
branch
2 times, most recently
from
8ddc009 to
c9821ed
Compare
tatiana
reviewed
Jun 24, 2025
tatiana
left a comment
tatiana
left a comment
Collaborator
There was a problem hiding this comment.
It's really exciting to see all the new scheduling support in DAG Factory, @pankajastro , while still being backwards compatible. Excellent work! I left some comments inline.
pankajastro
force-pushed
the
fix_schedule
branch
2 times, most recently
from
143767e to
30eadfc
Compare
pankajastro
force-pushed
the
fix_schedule
branch
from
e2f91d7 to
16bb041
Compare
tatiana
approved these changes
Jun 26, 2025
tatiana
left a comment
tatiana
left a comment
Collaborator
There was a problem hiding this comment.
It looks great, thanks a lot, @pankajastro !
pankajastro
force-pushed
the
fix_schedule
branch
from
df35bfa to
0df9152
Compare
pankajastro
force-pushed
the
fix_schedule
branch
from
0df9152 to
dd32a12
Compare
pankajastro
added a commit
that referenced
this pull request
Jun 27, 2025
While working on [PR #413](#413), I noticed that the schedule parameter is currently inconsistent and lacks clear documentation. It's difficult to determine what formats are supported without diving into the codebase. This PR proposes changes to make the schedule configuration more predictable, consistent, and easier to understand for users.
Merged
pankajastro
added a commit
that referenced
this pull request
Jul 14, 2025
## [0.23.0] - 2025-07-14 ### Breaking Change - Drop Airflow 2.2 Support by @pankajastro in [#388](#388) - Drop Python 3.8 support by @pankajastro in [#435](#435) - Drop Airflow 2.3 Support by @pankajastro in [#456](#456) ### Airflow 3 Support - Add tools for Dag-factory Airflow3 testing by @pankajastro in [#395](#395) - Fix schedule args for Airflow 3 by @pankajastro in [#413](#413) - Fix import path for BranchPythonOperator, PythonOperator and PythonSensor by @pankajastro in [#414](#414) - Add scheduling docs for Airflow 3 by @pankajastro in [#424](#424) - Enable Airflow 3 tests in CI by @pankajastro in [#436](#436) - Add env AUTO_CONVERT_TO_AF3 in Dockerfile by @pankajastro in [#455](#455) - Validate DAG's on Airflow 3 by @pankajastro in [#457](#457) - Refactor schedule to use the Python object @pankajastro in [#458](#458) - Fix CI and import issues for Airflow 3 compatibility @pankajastro in [#463](#463) ### Added - Add support for defining inlets by @IvanSviridov in [#380](#380) - Add HttpOperator JSON serialization support with tests by @a-chumagin in [#382](#382) - Add support for custom Python object by @pankajastro in [#444](#444) - Support env var in default by @gyli in [#452](#452) - Pass default arguments via dictionary in .py file by @jroachgolf84 in [#465](#465) ### Fixed - Remediated ``default`` behavior, added documentation by @jroachgolf84 in [#378](#378) - Upgrade `apache-airflow-providers-cncf-kubernetes` provider by @pankajastro in [#407](#407) - Include error message trace in exception by @pankajastro in [#408](#408) ### Docs - Remove Unreleased heading section from the CHANGELOG.md by @pankajkoti in [#365](#365) - Add Documentation for Conditional Dataset Scheduling with dag-factory by @ErickSeo in [#367](#367) - Add copy right in docs footer by @pankajastro in [#371](#371) - Updating docs for callbacks by @jroachgolf84 in [#375](#375) - Add stable/latest version in docs by @pankajastro in [#391](#391) - Migrate old content to new documentation structure by @pankajastro in [#393](#393) - Update Airflow supported version 2.3+ in docs by @pankajastro in [#412](#412) - Doc: Add step to fork repo in contributing guide by @pankajastro in [#427](#427) - Add setting CONFIG_ROOT_DIR in the contribution doc by @gyli in [#432](#432) - Add DAG example showcasing runtime params usage by @pankajastro in [#449](#449) - Add jinja2 template example by @pankajastro in [#450](#450) ### Others - Add Scraf Pixels for telemetry by @pankajastro in [#373](#373) - feat: bumped http provider versions to 2.0+ by @a-chumagin in [#389](#389) - Add --verbosity debug in astro-cli cmd by @pankajastro in [#390](#390) - Add missing Python file for dynamic task example by @pankajastro in [#392](#392) - Pin apache-airflow-providers-cncf-kubernetes<10.4.2 by @pankajastro in [#400](#400) - Add script to check version and tag by @pankajastro in [#395](#394) - Assert DagRunState in integration test by @pankajastro in [#415](#415) - Move to uv for package management by @jlaneve in [#419](#419) - Install uv in CI by @jlaneve in [#421](#421) - Bump astral-sh/setup-uv from 5 to 6 by @dependabot in [#423](#423) - Add Airflow 2.11 in test matrix by @pankajastro in [#425](#425) - fix example_dag_factory.yml typo causing catchup: false to not be respected by @RNHTTR in [#431](#431) - Remove expandvars in utils.get_python_callable by @gyli in [#440](#440) - Delete unused img folder by @pankajastro in [#446](#446) - Clean print statement by @pankajastro [#447](#447) - Add hatch to uv dev dependencies by @gyli in [#453](#453) - Add Authorize Job in CI by @pankajastro in [#460](#460) - Remove PyPI token for releasing packages by @tatiana in [#461](#461) - Change CI on trigger event to pull_request from pull_request_target by @pankajkoti in [#464](#464) - Update cicd.yaml: Use pull_request for authorize as we don't have pull_request_target event configured by @pankajkoti in [#466](#466) - Add environment for pypi publish job by @pankajastro in [#478](#478)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #399
Documentation PR: #424
This PR adds support for handling the schedule parameter across various types of scheduling formats in DAG configuration. The changes in this PR is only apply to Airflow 3 users.
For detailed usage examples and documentation, please refer to:
#424