Skip to content

Add GH action job to deploy docs#342

Merged
pankajastro merged 8 commits into
mainfrom
docs_job
Jan 8, 2025
Merged

Add GH action job to deploy docs#342
pankajastro merged 8 commits into
mainfrom
docs_job

Conversation

@pankajastro

@pankajastro pankajastro commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

closes: #279

This PR includes the following changes

  1. Add CI job to deploy docs
  2. Introduced command hatch run docs:dev to locally build and serve docs
  3. Remove hatch run docs:serve command
  4. Rename hatch run docs:build to hatch run docs: gh_deploy
  5. Rename hatch run docs:release to hatch run docs: gh_release

@codecov-commenter

codecov-commenter commented Jan 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (a85044c) to head (9291603).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files          10       10           
  Lines         792      792           
=======================================
  Hits          742      742           
  Misses         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread .github/workflows/docs.yaml Outdated
Comment thread pyproject.toml
@pankajastro pankajastro marked this pull request as ready for review January 6, 2025 14:53
@pankajastro pankajastro requested a review from a team as a code owner January 6, 2025 14:53
Comment thread .github/workflows/docs.yaml Outdated
Comment thread .github/workflows/docs.yaml Outdated

@pankajkoti pankajkoti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great to me @pankajastro . Have some minor suggestions in-line.

Comment thread .github/workflows/docs.yaml Outdated
Comment thread .github/workflows/docs.yaml Outdated
Comment thread pyproject.toml Outdated
Comment thread .github/workflows/docs.yaml Outdated
Comment thread .github/workflows/docs.yaml Outdated

@tatiana tatiana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pankajastro excellent progress, and thanks for fixing the previous unintended publishing issue I introduced in #328

We should not publish documents using our personal credentials. Please let me know if you need support on this.

Please, could you also update the docs so they are correct:
https://github.com/astronomer/dag-factory/blob/main/docs/contributing/howto.md#write-docs

Some other concerns:

  • It may be worth only to publish docs if static checks pass (and perhaps other tests, since we're exposing code)
  • When we merge PRs to the main branch, I believe we should update the "dev" or "unstable" docs only
  • We should probably update the "versioned" documents only when we publish a new version of DAG Factory to PyPI

@pankajkoti

Copy link
Copy Markdown
Contributor
  • When we merge PRs to the main branch, I believe we should update the "dev" or "unstable" docs only
  • We should probably update the "versioned" documents only when we publish a new version of DAG Factory to PyPI

I believe these 2 are already taken care of, no?

@tatiana

tatiana commented Jan 7, 2025

Copy link
Copy Markdown
Collaborator
  • When we merge PRs to the main branch, I believe we should update the "dev" or "unstable" docs only
  • We should probably update the "versioned" documents only when we publish a new version of DAG Factory to PyPI

I believe these 2 are already taken care of, no?

You're right, @pankajkoti; these should be working as I described; I missed this in the first look!

Comment thread .github/workflows/docs.yaml Outdated
@pankajastro pankajastro force-pushed the docs_job branch 2 times, most recently from fef4069 to 37b4231 Compare January 8, 2025 10:59
Comment thread .github/workflows/cicd.yaml Outdated

@tatiana tatiana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for addressing all the feedback, @pankajastro , I'm super excited to see the improvements we're making to the docs published - with versions!

@tatiana

tatiana commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator

@pankajastro please, before merging this PR, update the docs: https://github.com/astronomer/dag-factory/blob/main/docs/contributing/howto.md#write-docs

@pankajastro pankajastro merged commit a82905f into main Jan 8, 2025
@pankajastro pankajastro deleted the docs_job branch January 8, 2025 15:53
pankajastro added a commit that referenced this pull request Jan 10, 2025
This PR improves the initial docs deploy job that was introduced in PR:
#342

Add script for the docs deployment

- For pre-release, deploy at `dev`
- For release, deploy at version
- For PR, deploy at `dev`
@pankajkoti pankajkoti mentioned this pull request Jan 10, 2025
@tatiana tatiana added this to the DAG Factory 0.22.0 milestone Jan 10, 2025
tatiana pushed a commit that referenced this pull request Jan 10, 2025
### Added

- Propagate provided dag_display_name to built dag by @pankajkoti in
#326
- Add incipient documentation tooling by @tatiana in #328
- Support loading `default_args` from shared `defaults.yml` by
@pankajastro in #330
- Add security policy by @tatiana in #339
- Add Robust Support for Callbacks at Task and TaskGroup Level by
@@jroach-astronomer in #322
- Support `ExternalTaskSensor` `execution_date_fn` and `execution_delta`
by @tatiana in #354
- Refactor and add support for schedule conditions in DAG configuration
by @ErickSeo in #320

### Fixed

- Handle gracefully exceptions during telemetry collection by @tatiana
in #335
- Adjust `markdownlint` configuration to enforce 4-space indentation for
proper `mkdocs` rendering by @pankajkoti in #345

### Docs

- Create initial documentation index by @tatiana in #325
- Use absolute URLs for failing links in docs/index.md by @pankajkoti in
#331
- Add quick start docs by @pankajastro in #324
- Add docs comparing Python and YAML-based DAGs by @tatiana in #327
- Add docs about project contributors and their roles by @tatiana in
#341
- Add documentation to support developers by @tatiana in #343
- Add docs for configuring workflows, environment variables and defaults
by @pankajkoti in #338
- Add code of conduct for contributors and DAG factory community by
@tatiana in #340
- Document Dynamic Task Mapping feature by @pankajkoti in #344
- Fix warning message 404 in code_of_conduct docs by @pankajastro in
#346
- Update theme for documentation by @pankajastro in #348
- Fix markdownlint errors and some rendering improvements by
@pankajastro in #356
- Reword content in documentation by @yanmastin-astro in #336

### Others

- Improve integration tests scripts by @tatiana in #316
- Add Markdown pre-commit checks by @tatiana in #329
- Remove Airflow <> 2.0.0 check by @pankajastro in #334
- Reduce telemetry timeout from 5 to 1 second by @tatiana in #337
- Add GH action job to deploy docs by @pankajastro in #342
- Enable Depandabot to scan outdated Github Actions dependencies by
@tatiana in #347
- Improve docs deploy job by @pankajastro in #352
- Unify how we build dagfactory by @tatiana in #353
- Fix running make docker run when previous versions were run locally by
@tatiana in #362
- Install `jq` in `dev` container by @pankajastro in #363
- Dependabot GitHub actions version upgrades in #349, #350, #351


Closes: #306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Host user-facing DAG Factory docs

5 participants