From 7e37f2f29a8c1a09308a3487df690b3d0cd64e4b Mon Sep 17 00:00:00 2001 From: Tatiana Al-Chueyr Date: Sat, 4 Jan 2025 10:43:43 +0000 Subject: [PATCH] Reduce timeout from 5 to 1 second We had an unreasonably high timeout - reducing to a more acceptable one --- dagfactory/constants.py | 2 +- tests/test_telemetry.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dagfactory/constants.py b/dagfactory/constants.py index 4ca9f26f..e591a600 100644 --- a/dagfactory/constants.py +++ b/dagfactory/constants.py @@ -1,3 +1,3 @@ TELEMETRY_URL = "https://astronomer.gateway.scarf.sh/dag-factory/{telemetry_version}/{dagfactory_version}/{airflow_version}/{python_version}/{platform_system}/{platform_machine}/{event_type}/{status}/{dag_hash}/{task_count}" TELEMETRY_VERSION = "v2" -TELEMETRY_TIMEOUT = 5.0 +TELEMETRY_TIMEOUT = 1.0 diff --git a/tests/test_telemetry.py b/tests/test_telemetry.py index d2d726a9..aec261a8 100644 --- a/tests/test_telemetry.py +++ b/tests/test_telemetry.py @@ -61,7 +61,7 @@ def test_emit_usage_metrics_is_unsuccessful(mock_httpx_get, caplog): is_success = telemetry.emit_usage_metrics(sample_metrics) mock_httpx_get.assert_called_once_with( f"""https://astronomer.gateway.scarf.sh/dag-factory/v2/0.2.0a1/2.10.1/3.11/darwin/amd64/dag_run/success/d151d1fa2f03270ea116cc7494f2c591/3""", - timeout=5.0, + timeout=1.0, follow_redirects=True, ) assert not is_success @@ -86,7 +86,7 @@ def test_emit_usage_metrics_fails(mock_httpx_get, caplog): is_success = telemetry.emit_usage_metrics(sample_metrics) mock_httpx_get.assert_called_once_with( f"""https://astronomer.gateway.scarf.sh/dag-factory/v2/0.2.0a1/2.10.1/3.11/darwin/amd64/dag_run/success/d151d1fa2f03270ea116cc7494f2c591/3""", - timeout=5.0, + timeout=1.0, follow_redirects=True, ) assert not is_success