fix: Replace login by user for clickhouse profile#1255
Merged
pankajastro merged 1 commit intoOct 16, 2024
Conversation
dosubot
Bot
added
the
size:XS
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
pankajastro
approved these changes
Oct 15, 2024
pankajastro
left a comment
pankajastro
left a comment
Contributor
There was a problem hiding this comment.
Looks great, @petershenri Thank you for fixing it.
Contributor
Author
|
Can I let you merge it to main ? |
dosubot
Bot
added
size:S
Contributor
We will merge it once CI is green |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 67 67
Lines 3965 3965
=======================================
Hits 3796 3796
Misses 169 169 ☔ View full report in Codecov by Sentry. |
Collaborator
|
@petershenri, thank you very much for reporting/fixing this issue. |
Contributor
Author
|
It works as expected on my docker. |
tatiana
added a commit
that referenced
this pull request
Oct 29, 2024
Bug fixes * Fix ``DbtVirtualenvBaseOperator`` to use correct virtualenv Python path by kesompochy in #1252 * Fix displaying dbt docs as menu item in Astro by @tatiana in #1280 * Fix: Replace login by user for clickhouse profile by @petershenri in #1255 Enhancements * Improve dbt Docs Hosting Debugging -- Update dbt_docs_not_set_up.html by @johnmcochran in #1250 * Minor refactor on VirtualenvOperators & add test for PR by @tatiana in #1253 Docs * Add Welcome Section and "What Is Cosmos" Blurb to Home Page by @cmarteepants and @yanmastin-astro in #1251 * Update the URL for sample dbt docs hosted in Astronomer S3 bucket by @pankajkoti in #1283 * Add dedicated scarf tracking pixel to readme by @cmarteepants in #1256 Others * Update ``CODEOWNERS`` to track all files by @pankajkoti in #1284 * Fix release after the ``raw`` rst directive disabled was disabled in PyPI by @tatiana in #1282 * Update issue template ``bug.yml`` - cosmos version update in the dropdown by @pankajkoti in #1275 * Pre-commit hook updates in #1285, #1274, #1254, #1244" error: pathspec 'Is' did not match any file(s) known to git error: pathspec 'Cosmos Blurb to Home Page by @cmarteepants and @yanmastin-astro in #1251 * Update the URL for sample dbt docs hosted in Astronomer S3 bucket by @pankajkoti in #1283 * Add dedicated scarf tracking pixel to readme by @cmarteepants in #1256 Others * Update CODEOWNERS to track all files by @pankajkoti in #1284 * Fix release after the raw rst directive disabled was disabled in PyPI by @tatiana in #1282 * Update issue template bug.yml - cosmos version update in the dropdown by @pankajkoti in #1275 * Pre-commit hook updates in #1285, #1274, #1254, #1244
Merged
tatiana
added a commit
that referenced
this pull request
Oct 29, 2024
Bug fixes * Fix ``DbtVirtualenvBaseOperator`` to use correct virtualenv Python path by kesompochy in #1252 * Fix displaying dbt docs as menu item in Astro by @tatiana in #1280 * Fix: Replace login by user for clickhouse profile by @petershenri in #1255 Enhancements * Improve dbt Docs Hosting Debugging -- Update dbt_docs_not_set_up.html by @johnmcochran in #1250 * Minor refactor on VirtualenvOperators & add test for PR by @tatiana in #1253 Docs * Add Welcome Section and "What Is Cosmos" Blurb to Home Page by @cmarteepants and @yanmastin-astro in #1251 * Update the URL for sample dbt docs hosted in Astronomer S3 bucket by @pankajkoti in #1283 * Add dedicated scarf tracking pixel to readme by @cmarteepants in #1256 Others * Update ``CODEOWNERS`` to track all files by @pankajkoti in #1284 * Fix release after the ``raw`` rst directive disabled was disabled in PyPI by @tatiana in #1282 * Update issue template ``bug.yml`` - cosmos version update in the dropdown by @pankajkoti in #1275 * Pre-commit hook updates in #1285, #1274, #1254, #1244" error: pathspec 'Is' did not match any file(s) known to git error: pathspec 'Cosmos Blurb to Home Page by @cmarteepants and @yanmastin-astro in #1251 * Update the URL for sample dbt docs hosted in Astronomer S3 bucket by @pankajkoti in #1283 * Add dedicated scarf tracking pixel to readme by @cmarteepants in #1256 Others * Update CODEOWNERS to track all files by @pankajkoti in #1284 * Fix release after the raw rst directive disabled was disabled in PyPI by @tatiana in #1282 * Update issue template bug.yml - cosmos version update in the dropdown by @pankajkoti in #1275 * Pre-commit hook updates in #1285, #1274, #1254, #1244
tatiana
added a commit
that referenced
this pull request
Oct 29, 2024
Bug fixes * Fix ``DbtVirtualenvBaseOperator`` to use correct virtualenv Python path by @kesompochy in #1252 * Fix displaying dbt docs as menu item in Astro by @tatiana in #1280 * Fix: Replace login by user for clickhouse profile by @petershenri in #1255 Enhancements * Improve dbt Docs Hosting Debugging -- Update dbt_docs_not_set_up.html by @johnmcochran in #1250 * Minor refactor on VirtualenvOperators & add test for PR by @tatiana in #1253 Docs * Add Welcome Section and "What Is Cosmos" Blurb to Home Page by @cmarteepants and @yanmastin-astro in #1251 * Update the URL for sample dbt docs hosted in Astronomer S3 bucket by @pankajkoti in #1283 * Add a dedicated scarf tracking pixel to readme by @cmarteepants in #1256 Others * Update ``CODEOWNERS`` to track all files by @pankajkoti in #1284 * Fix release after the ``raw`` rst directive disabled was disabled in PyPI by @tatiana in #1282 * Update issue template ``bug.yml`` - cosmos version update in the dropdown by @pankajkoti in #1275 * Pre-commit hook updates in #1285, #1274, #1254, #1244
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The clickhouse profile is currently not working. Changing the login parameter to user
Related Issue(s)
closes #1249
Breaking Change?
No
Checklist