Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conductor: fetch sequencer and rollup blobs from celestia in one RPC #491

Closed
SuperFluffy opened this issue Oct 12, 2023 · 4 comments
Closed
Labels
celestia interacting with celestia conductor pertaining to the astria-conductor crate

Comments

@SuperFluffy
Copy link
Member

SuperFluffy commented Oct 12, 2023

At the moment conductor first fetches sequencer data for a given height, followed by its rollup data. That is unecessary since we can fetch both at in one blob.GetAll RPC.

@SuperFluffy SuperFluffy changed the title conductor: fetch sequencer and rollup blobs in one blob.GetAll conductor: fetch sequencer and rollup blobs in one blob.GetAll RPC Oct 12, 2023
@SuperFluffy SuperFluffy changed the title conductor: fetch sequencer and rollup blobs in one blob.GetAll RPC conductor: fetch sequencer and rollup blobs from celestia in one RPC Oct 12, 2023
@SuperFluffy SuperFluffy added celestia interacting with celestia conductor pertaining to the astria-conductor crate labels Oct 12, 2023
@noot
Copy link
Collaborator

noot commented Oct 16, 2023

does your PR #487 fix this?

@noot
Copy link
Collaborator

noot commented Jan 1, 2024

closing as it's implemented

@noot noot closed this as completed Jan 1, 2024
@SuperFluffy SuperFluffy reopened this Jan 1, 2024
@SuperFluffy
Copy link
Member Author

SuperFluffy commented Jan 1, 2024

This is not yet implemented. We are currently first fetching the blobs in the sequencer namespace followed by a separate fetch of the desired rollup namespace:

  1. fetching the CelestiaSequencerBlob:
    .get_sequencer_blobs(height, sequencer_namespace)
  2. fetching the CelestiaRollupBlob:
    .get_rollup_blobs_matching_sequencer_blob(height, rollup_namespace, &blob)

@SuperFluffy
Copy link
Member Author

SuperFluffy commented May 28, 2024

It turns out that Celestia does not quite allow our use case: blobs for several namespaces at a given height can be fetched if and only if there exist blobs for all namespaces at that height. For example, if we desire to fetch blobs for namespaces foo and bar at Celestia height 10 and a blob at bar does not exist, then blob.GetAll will return an error, see this issue: celestiaorg/celestia-node#3292
Closing the issue because we will not be able to implement it for the foreseeable future.

@SuperFluffy SuperFluffy closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
celestia interacting with celestia conductor pertaining to the astria-conductor crate
Projects
None yet
Development

No branches or pull requests

2 participants