Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Implement SweetAlert #136

Closed
bntzio opened this issue Apr 17, 2017 · 21 comments
Closed

[enhancement] Implement SweetAlert #136

bntzio opened this issue Apr 17, 2017 · 21 comments

Comments

@bntzio
Copy link

bntzio commented Apr 17, 2017

Hello @syropian, nice work on astral!

I noticed that the app shows default browser alerts (deleting a tag), what do you think about implementing SweetAlert to improve the design?

I'll be happy to submit a PR. 😃

@bntzio bntzio changed the title Implement SweetAlert [enhancement] Implement SweetAlert Apr 17, 2017
@syropian
Copy link
Member

I'd be happy to accept a PR. One note is, instead of showing a follow-up success SweetAlert, just close the modal after they confirm they want to delete as there's already an existing notification module that indicates success or failure.

@bntzio
Copy link
Author

bntzio commented Apr 19, 2017

@syropian I got an error when trying to run the app.

error

Why is that? Also, when trying to do:

php artisan migrate

I get the following errors:

error2

@bntzio
Copy link
Author

bntzio commented Apr 19, 2017

Here's my Github's OAuth App settings:

oauth

And here's my .env file:

dotenv

@alexbowers
Copy link

The database doesn't exist.

Either change the database to be sqlite, or create the database in mysql and change the database details to be correct DB_DATABASE, DB_USERNAME and DB_PASSWORD.

@bntzio
Copy link
Author

bntzio commented Apr 21, 2017

@alexbowers Ok so I got it running now, I used homestead instead, now I got another problem, I can't build the js/css neither w/webpack or gulp.

What I did was a simple change to a vue component, but I need to watch for that changes and compile the js, I tried with npm run watch and npm run dev but none worked.

Also, I tried using gulp and gulp watch and it appeared that some packages weren't installed (like gulp-notify, karma, laravel-elixir, and so on) 🤔.

I installed those dependencies with npm i --save-dev and the gulp worked.

The thing is, when I go to astralapp.app I see this error message:

Unable to locate Mix file: /css/app.css. Please check your webpack.mix.js output paths and try again. (View: /home/vagrant/astral/resources/views/index.blade.php)

I don't know why I can't compile js/css, how do you do it?

I already did npm install as mentioned in the readme so everything should properly work without any issues, but it isn't working for me.

@bntzio
Copy link
Author

bntzio commented Apr 21, 2017

I think something is wrong with the mozjpeg package, when I do a npm install I get this:

Then all dependencies installs normally.

And when I do npm run dev or npm run watch I get this:

That's why I can't handle the js/css compilation using webpack, so I tried gulp but as mentioned earlier, I got errors, the easier way I think, is using webpack, but this error appears.

@syropian
Copy link
Member

gulp is no longer used, it's all Laravel Mix. What's your node and npm version?

@bntzio
Copy link
Author

bntzio commented Apr 21, 2017

node: v6.4.0
npm: 3.10.3

@syropian
Copy link
Member

syropian commented Apr 21, 2017

Do you have nvm installed? I'm currently using Node 7.3.0 myself. Not sure if that's the problem or not.

@syropian
Copy link
Member

syropian commented Apr 21, 2017

I just blew away my node_modules folder and ran npm install && npm run dev and everything worked fine for me.

OS: macOS 10.12.4
Node: 7.3.0
npm: 3.10.3

@bntzio
Copy link
Author

bntzio commented Apr 21, 2017

Yep, I do. I just installed 7.3.0 and ran npm run reinstall-deps same error.

@bntzio
Copy link
Author

bntzio commented Apr 21, 2017

Mmm... what could it be. When you run npm run dev aren't u getting errors?

@syropian
Copy link
Member

Nope, not getting any errors at all.

@syropian
Copy link
Member

@bntzio Are you using homebrew? Check that your copy of libpng is linked properly.

brew link --overwrite libpng

@bntzio
Copy link
Author

bntzio commented Apr 21, 2017

Yes, I'm into it.

Are you using webpack 2?

@syropian
Copy link
Member

afaik Laravel Mix uses webpack 2 by default.

@bntzio
Copy link
Author

bntzio commented Apr 21, 2017

@syropian I got it working now! 🎉 the problem was with libpng.

Solution:

  1. brew install libpng
  2. brew link libpng

Just as you mentioned earlier 👍

It seems that some people are having problems with this as well -> unable to load image files issue

@bntzio
Copy link
Author

bntzio commented Apr 21, 2017

Now when I run npm run dev everything works fine.

Thank you for ur time @syropian

Now I'll go back to implement the SweetAlert.

@syropian
Copy link
Member

Awesome! Really glad you got it sorted, it's good to have these issues in the open in case anyone runs into something similar. Cheers!

@bntzio
Copy link
Author

bntzio commented Apr 24, 2017

PR ready! 😄 #138

@syropian
Copy link
Member

Added in #138 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants