Implement uv tree
#4708
Open
Implement uv tree
#4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
approved these changes
Jul 1, 2024
ibraheemdev
force-pushed
the
ibraheem/uv-tree
branch
2 times, most recently
from
30eb67f
to
579bc1e
Compare
zanieb
reviewed
Jul 2, 2024
crates/uv/tests/common/mod.rs
Outdated
| @@ -302,7 +302,7 @@ impl TestContext { | |||
| if cfg!(all(windows, debug_assertions)) { | |||
| // TODO(konstin): Reduce stack usage in debug mode enough that the tests pass with the | |||
| // default windows stack of 1MB | |||
| command.env("UV_STACK_SIZE", (8 * 1024 * 1024).to_string()); | |||
There was a problem hiding this comment.
Please update the contributing guide too
konstin
added a commit
that referenced
this pull request
Jul 3, 2024
Fix windows stack sizes for #4708 In this case, box clap arguments so that clap parsing can be done in the default 1MB stack on windows.
konstin
added a commit
that referenced
this pull request
Jul 3, 2024
The changes in #4708 caused an overflow in debug mode only of the 1MB default stack size in windows during clap. This means that even trivial wrong argument tests would fail without increasing the stack size. As remedy, we box the clap types.
konstin
added a commit
that referenced
this pull request
Jul 3, 2024
Fix windows stack sizes for #4708 In this case, box clap arguments so that clap parsing can be done in the default 1MB stack on windows.
konstin
added a commit
that referenced
this pull request
Jul 3, 2024
The changes in #4708 caused an overflow in debug mode only of the 1MB default stack size in windows during clap. This means that even trivial wrong argument tests would fail without increasing the stack size. As remedy, we box the clap types.
ibraheemdev
force-pushed
the
ibraheem/uv-tree
branch
from
ddcad05
to
4d7dca4
Compare
ibraheemdev
force-pushed
the
ibraheem/uv-tree
branch
from
4d7dca4
to
ad38914
Compare
|
I expect that #4796 (box the project commands type) will also fix the tests here. How do you want to proceeed @ibraheemdev? I can make the changes from #4796 but it will cause merge conflicts with both this and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
uv tree, which displays dependencies from the lockfile as a tree. Resolves #4699.