Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate unnamed URL and editable URL parsing #3942

Closed
charliermarsh opened this issue May 31, 2024 · 1 comment · Fixed by #3946
Closed

Deduplicate unnamed URL and editable URL parsing #3942

charliermarsh opened this issue May 31, 2024 · 1 comment · Fixed by #3946
Assignees
@charliermarsh
Labels
bug Something isn't working internal A refactor or improvement that is not user-facing

Comments

@charliermarsh
Copy link
Member

I think the requirements here are identical, but we have two totally separate paths for them (and now have some bugs for unnamed URLs that we already fixed for editables).
@charliermarsh charliermarsh added bug Something isn't working internal A refactor or improvement that is not user-facing labels May 31, 2024
@charliermarsh
Copy link
Member Author

For example: ./scripts/packages/black_editable[colorama, uvloop] doesn't work, but -e ./scripts/packages/black_editable[colorama, uvloop] does.

@charliermarsh charliermarsh self-assigned this May 31, 2024
@charliermarsh charliermarsh mentioned this issue May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working internal A refactor or improvement that is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify editable and unnamed URL parsing astral-sh/uv
1 participant
@charliermarsh