Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about space efficiency of the git cache #1760

Open
sbidoul opened this issue Feb 20, 2024 · 2 comments
Open

Question about space efficiency of the git cache #1760

sbidoul opened this issue Feb 20, 2024 · 2 comments
Assignees
Labels
cache Caching of packages and metadata question Asking for clarification or support

Comments

@sbidoul
Copy link

sbidoul commented Feb 20, 2024

If I understand correctly, installing from git URL creates the following in the uv cache:

  1. the git objects in git-v0/db
  2. a git checkout in git-v0/checkouts (with hardlinks to the git objects but copies of the source files)
  3. the built wheel in wheels-v0
  4. an extract of the built wheel archive-v0, from which the installed files are hard linked (or CoW'ed)

My question is: is it important to keep (2) when we have (3), and maybe (3) when we have (4)?
Are there situations where checkouts (2) are actually read again in subsequent installs?

@charliermarsh charliermarsh self-assigned this Feb 20, 2024
@charliermarsh
Copy link
Member

I'm the right person to answer this but I need to think a bit on some of the questions (and am trying to prioritize correctness issues). My initial reaction is that (3) is probably not necessary (but we tend to avoid trying to delete from the cache to prevent against concurrency issues).

@charliermarsh charliermarsh added question Asking for clarification or support cache Caching of packages and metadata labels Feb 20, 2024
@sbidoul
Copy link
Author

sbidoul commented Feb 21, 2024

My initial reaction is that (3) is probably not necessary

In connection with pip wheel (#1681), I think (3) is useful, probably more than (2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cache Caching of packages and metadata question Asking for clarification or support
Projects
None yet
Development

No branches or pull requests

2 participants