-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix binary expression formatting with leading comments #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Merged
MichaReiser
added
internal
An internal refactor or improvement
formatter
Related to the formatter
labels
Jun 8, 2023
konstin
approved these changes
Jun 8, 2023
MichaReiser
force-pushed
the
format-if-statement
branch
from
June 8, 2023 15:34
b25a3ac
to
226aabf
Compare
MichaReiser
force-pushed
the
fix-bin-oip-with-leading-comments
branch
2 times, most recently
from
June 8, 2023 15:37
7e0f1f6
to
5e7fb65
Compare
MichaReiser
force-pushed
the
format-if-statement
branch
from
June 8, 2023 16:10
226aabf
to
b9826c1
Compare
MichaReiser
force-pushed
the
fix-bin-oip-with-leading-comments
branch
from
June 8, 2023 16:10
5e7fb65
to
4cf24dc
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinux
Windows
|
This was referenced Jun 9, 2023
MichaReiser
force-pushed
the
fix-bin-oip-with-leading-comments
branch
from
June 9, 2023 08:46
4cf24dc
to
7458b5b
Compare
MichaReiser
force-pushed
the
fix-bin-oip-with-leading-comments
branch
from
June 9, 2023 08:56
7458b5b
to
e341c1c
Compare
konstin
pushed a commit
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where
got formatted differently on the second pass.
It now preserves the formatting, the same as Black.
Test Plan
I added a new test