Skip to content

[ty] Remove the mypy_primer CI workflow #24016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharkdp merged 1 commit into from
Mar 17, 2026
+18 −345
Merged

[ty] Remove the mypy_primer CI workflow #24016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/actionlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,3 @@ self-hosted-runner:
- github-windows-2025-x86_64-8
- github-windows-2025-x86_64-16
- codspeed-macro

paths:
".github/workflows/mypy_primer.yaml":
ignore:
- 'constant expression "false" in condition. remove the if: section'
2 changes: 1 addition & 1 deletion .github/mypy-primer-ty.toml → .github/ty-ecosystem.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#:schema ../ty.schema.json
# Configuration overrides for the mypy primer run
# Configuration overrides for ty ecosystem analysis

# Enable off-by-default rules.
[rules]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/memory_report.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
- "!**.md"
- "!**.snap"
# It's tempting to skip all Python files in every directory,
# but changes to Python files in `ty_vendored` can affect the output of mypy_primer,
# but changes to Python files in `ty_vendored` can affect the output of ecosystem runs,
# so we apply a narrow exemption for all files in the corpus directory instead.
- "!crates/ty_python_semantic/resources/corpus/**"

Expand Down
124 changes: 0 additions & 124 deletions .github/workflows/mypy_primer.yaml
View file
Open in desktop

This file was deleted.

9 changes: 4 additions & 5 deletions .github/workflows/ty-ecosystem-analyzer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ on:
- "crates/ruff_python_ast"
- "crates/ruff_python_parser"
- ".github/workflows/ty-ecosystem-analyzer.yaml"
- ".github/workflows/mypy_primer.yaml"
- "scripts/mypy_primer.sh"
- "scripts/mypy_primer_selector.py"
- ".github/ty-ecosystem.toml"
- "crates/ty_python_semantic/resources/primer/**"
Copy link
Copy Markdown
Contributor Author

@sharkdp sharkdp Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is new. seems reasonable to run the workflow if good/bad/flaky.txt change

Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename the directory to crates/ty_python_semantic/resources/ecosystem/?

Copy link
Copy Markdown
Contributor Author

@sharkdp sharkdp Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what I did first, but then I reverted to keep the diff smaller. I like the plan of getting rid of those files, so I'm not going to spend time on renaming the folder now.

Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG

- "Cargo.lock"
- "!**.md"
- "!**.snap"
Expand Down Expand Up @@ -69,9 +68,9 @@ jobs:
run: |
cd ruff

echo "Enabling configuration overloads (see .github/mypy-primer-ty.toml)"
echo "Enabling configuration overloads (see .github/ty-ecosystem.toml)"
mkdir -p ~/.config/ty
cp .github/mypy-primer-ty.toml ~/.config/ty/ty.toml
cp .github/ty-ecosystem.toml ~/.config/ty/ty.toml

echo "new commit"
git checkout -b new_commit "$GITHUB_SHA"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ty-ecosystem-report.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ jobs:
run: |
cd ruff

echo "Enabling configuration overloads (see .github/mypy-primer-ty.toml)"
echo "Enabling configuration overloads (see .github/ty-ecosystem.toml)"
mkdir -p ~/.config/ty
cp .github/mypy-primer-ty.toml ~/.config/ty/ty.toml
cp .github/ty-ecosystem.toml ~/.config/ty/ty.toml

cd ..

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/typing_conformance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ on:
- "Cargo.lock"
- "!**.md"
- "!**.snap"
# It's tempting to skip all Python files in every directory,
# but changes to Python files in `ty_vendored` can affect the output of mypy_primer,
# It's tempting to skip all Python files in every directory, but changes to
# Python files in `ty_vendored` can affect the output of the ecosystem analysis,
# so we apply a narrow exemption for all files in the corpus directory instead.
- "!crates/ty_python_semantic/resources/corpus/**"

Expand Down
8 changes: 0 additions & 8 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ repos:
language: system
types: [rust]
priority: 0
- id: check-mypy-primer-sha
name: Check mypy-primer SHA is in sync
entry: python3 scripts/check_mypy_primer_sha.py
language: system
pass_filenames: false
files: ^scripts/(mypy_primer\.sh|setup_primer_project\.py)$
priority: 0

# Prettier
- repo: https://github.com/rbubley/mirrors-prettier
rev: v3.8.1
Expand Down
4 changes: 2 additions & 2 deletions crates/ruff_benchmark/benches/ty_walltime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ static STATIC_FRAME: Benchmark = Benchmark::new(
repository: "https://github.com/static-frame/static-frame",
commit: "34962b41baca5e7f98f5a758d530bff02748a421",
paths: &["static_frame"],
// N.B. `arraykit` is installed as a dependency during mypy_primer runs,
// but it takes much longer to be installed in a Codspeed run than it does in a mypy_primer run
// N.B. `arraykit` is installed as a dependency during ecosystem runs,
// but it takes much longer to be installed in a Codspeed run
// (seems to be built from source on the Codspeed CI runners for some reason).
dependencies: &["numpy"],
max_dep_date: "2025-08-09",
Expand Down
8 changes: 4 additions & 4 deletions crates/ty/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,11 @@ The property tests do not run in CI on every PR, just once daily. It is advisabl
locally after modifying core type relation methods (`is_subtype_of`, `is_equivalent_to`, etc.) to
ensure that the changes do not break any of the properties.

## Ecosystem CI (mypy-primer)
## Ecosystem CI (`ecosystem-analyzer`)

GitHub Actions will run your changes against a number of real-world projects from GitHub and
report on any linter or formatter differences. See [`crates/ty/docs/mypy_primer.md`](./docs/mypy_primer.md)
Copy link
Copy Markdown
Contributor Author

@sharkdp sharkdp Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter or formatter differences

🙃

for instructions on running these checks locally.
GitHub Actions will run your changes against a number of real-world projects from GitHub and report
any differences in ty's diagnostic output. You can use [`setup_primer_project.py`](./scripts/setup_primer_project.py)
to reproduce the same testing conditions locally.

## Coding guidelines

Expand Down
69 changes: 0 additions & 69 deletions crates/ty/docs/mypy_primer.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion crates/ty_python_semantic/src/types/tuple.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ impl<'db> TupleType<'db> {
}

// N.B. If this method is not Salsa-tracked, we take 10 minutes to check
// `static-frame` as part of a mypy_primer run! This is because it's called
// `static-frame` as part of the ecosystem analysis. This is because it's called
// from `NominalInstanceType::class()`, which is a very hot method.
#[salsa::tracked(cycle_initial=to_class_type_cycle_initial, heap_size=ruff_memory_usage::heap_size)]
pub(crate) fn to_class_type(self, db: &'db dyn Db) -> ClassType<'db> {
Expand Down
40 changes: 0 additions & 40 deletions scripts/check_mypy_primer_sha.py
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions scripts/mypy_primer.sh
View file
Open in desktop

This file was deleted.

Loading
Loading