Skip to content

Conversation

@TaKO8Ki
Copy link
Contributor

@TaKO8Ki TaKO8Ki commented Oct 21, 2025

Summary

Fixes a part of #15655

Auto generate ast Pattern nodes

Test Plan

I have fixed some syntax tests. All other tests should pass without any changes. I have confirmed the generated code to make sure it's the same as old code.

@TaKO8Ki TaKO8Ki changed the title Auto generate ast Pattern nodes [ruff] Auto generate ast Pattern nodes Oct 21, 2025
@TaKO8Ki
Copy link
Contributor Author

TaKO8Ki commented Oct 21, 2025

I have fixed some snapshots in ruff_python_parser/tests. If we change the order of node_index and range in generate.py, It's unnecessary. However, other definitions such as StmtExpr is already based on the fields order, so I will keep the following order.

pub node_index: crate::AtomicNodeIndex,
pub range: ruff_text_size::TextRange,

@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@amyreese amyreese requested a review from ntBre October 22, 2025 02:02
@amyreese amyreese added the parser Related to the parser label Oct 22, 2025
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Oct 22, 2025
@MichaReiser MichaReiser merged commit 6271fba into astral-sh:main Oct 22, 2025
39 checks passed
@TaKO8Ki TaKO8Ki deleted the autogenerate-pattern-nodes branch October 22, 2025 06:49
dcreager added a commit that referenced this pull request Oct 22, 2025
* main: (65 commits)
  [ty] Some more simplifications when rendering constraint sets (#21009)
  [ty] Make `attributes.md` mdtests faster (#21030)
  [ty] Set `INSTA_FORCE_PASS` and `INSTA_OUTPUT` environment variables from mdtest.py (#21029)
  [ty] Fall back to `Divergent` for deeply nested specializations (#20988)
  [`ruff`] Autogenerate TypeParam nodes (#21028)
  [ty] Add assertions to ensure that we never call `KnownClass::Tuple.to_instance()` or similar (#21027)
  [`ruff`] Auto generate ast Pattern nodes (#21024)
  [`flake8-simplify`] Skip `SIM911` when unknown arguments are present (#20697)
  Render a diagnostic for syntax errors introduced in formatter tests (#21021)
  [ty] Support goto-definition on vendored typeshed stubs (#21020)
  [ty] Implement go-to for binary and unary operators (#21001)
  [ty] Avoid ever-growing default types (#20991)
  [syntax-errors] Name is parameter and global (#20426)
  [ty] Disable panicking mdtest (#21016)
  [ty] Fix completions at end of file (#20993)
  [ty] Fix out-of-order semantic token for function with regular argument after kwargs (#21013)
  [ty] Fix auto import for files with `from __future__` import (#20987)
  [`fastapi`] Handle ellipsis defaults in FAST002 autofix (`FAST002`) (#20810)
  [`ruff`] Skip autofix for keyword and `__debug__` path params (#20960)
  [`flake8-bugbear`] Skip `B905` and `B912` if <2 iterables and no starred arguments (#20998)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement parser Related to the parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants