[pyupgrade] Always parenthesize assignment expressions in fix for f-string (UP032)
#21003
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylwil3
added
bug
dylwil3
force-pushed
the
up032-assignment-expr
branch
from
4d76d57 to
4db779c
Compare
MichaReiser
approved these changes
Oct 20, 2025
| _, | ||
| Expr::Generator(_) | ||
| | Expr::Dict(_) | ||
| | Expr::Named(_) |
Member
There was a problem hiding this comment.
It would be nice if we could use OperatorPrecedence here (I believe that's the name) instead of listing all expressions
Collaborator
Author
There was a problem hiding this comment.
Hm... it's not immediately clear how to do this here - especially because some of this logic is to avoid double escaped braces for sets and dicts, like f"{{x}}"
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21000