[ty] Add semantic token provider to playground #19232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
playground
Contributor
|
MichaReiser
force-pushed
the
micha/semantic-tokens-playground
branch
from
cf14a06 to
4940b31
Compare
UnboundVariable
approved these changes
Jul 10, 2025
Collaborator
UnboundVariable
left a comment
UnboundVariable
left a comment
There was a problem hiding this comment.
Thanks for doing this. LGTM.
| foreground: ROCK, | ||
| }, | ||
| { | ||
| foreground: ROCK, |
Collaborator
There was a problem hiding this comment.
It looks like a lot of work to maintain the theme colors manually. IIRC, there are theme packs for monaco that work well on dark and light background.
Member
Author
There was a problem hiding this comment.
Yeah, I considered doing the same. It's a bit unfortunate that it's not possible to use the VS code themes directly
Collaborator
There was a problem hiding this comment.
I think monaco offers some reasonable default themes, but maybe you're looking for something that's more customizable.
Here's the code in the "pyright playground" code that specifies the default VS Code theme.
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
UnboundVariable
pushed a commit
to UnboundVariable/ruff
that referenced
this pull request
Jul 11, 2025
…re_help * 'main' of https://github.com/astral-sh/ruff: Add simple integration tests for all output formats (astral-sh#19265) [`flake8-return`] Fix false-positive for variables used inside nested functions in `RET504` (astral-sh#18433) [ty] Add a `--quiet` mode (astral-sh#19233) Treat form feed as valid whitespace before a line continuation (astral-sh#19220) [ty] Make `check_file` a salsa query (astral-sh#19255) [ty] Consolidate submodule resolving code between `types.rs` and `ide_support.rs` (astral-sh#19256) [ty] Remove countme from salsa-structs (astral-sh#19257) [ty] Improve and document equivalence for module-literal types (astral-sh#19243) [ty] Optimize protocol subtyping by removing expensive and unnecessary equivalence check from the top of `Type::has_relation_to()` (astral-sh#19230) [ty] Ecosystem analyzer: parallelize, fix race condition (astral-sh#19252) [ty] Add completion kind to playground (astral-sh#19251) [ty] Deploy ecosystem diff to Cloudflare pages (astral-sh#19234) [ty] Add semantic token provider to playground (astral-sh#19232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrate the semantic token provider into the playground.
I did remap some colors but I didn't assign colors to every supported token yet
Test Plan