From ecf18723a1d4bcef43227d59a35e1e1a2bbb2b72 Mon Sep 17 00:00:00 2001 From: vasco Date: Tue, 29 Apr 2025 22:13:18 +0200 Subject: [PATCH 1/2] add fix safety section --- .../ruff/rules/invalid_formatter_suppression_comment.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs b/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs index b3fac6e6ca292..e994f4582f77e 100644 --- a/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs +++ b/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs @@ -49,6 +49,12 @@ use super::suppression_comment_visitor::{ /// # fmt: on /// # yapf: enable /// ``` +/// +/// ## Fix safety +/// +/// The fix is always marked as unsafe because it's not possible to clearly determine +/// the user's true intent behind the suppression statement. +/// #[derive(ViolationMetadata)] pub(crate) struct InvalidFormatterSuppressionComment { reason: IgnoredReason, From 7fadaa4a8eb9bbe38de2ea75a8575804df8a8944 Mon Sep 17 00:00:00 2001 From: Vasco Schiavo <115561717+VascoSch92@users.noreply.github.com> Date: Wed, 30 Apr 2025 18:45:49 +0200 Subject: [PATCH 2/2] Update invalid_formatter_suppression_comment.rs --- .../rules/ruff/rules/invalid_formatter_suppression_comment.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs b/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs index e994f4582f77e..2293071d0e0eb 100644 --- a/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs +++ b/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs @@ -52,8 +52,8 @@ use super::suppression_comment_visitor::{ /// /// ## Fix safety /// -/// The fix is always marked as unsafe because it's not possible to clearly determine -/// the user's true intent behind the suppression statement. +/// This fix is always marked as unsafe because it deletes the invalid suppression comment, +/// rather than trying to move it to a valid position, which the user more likely intended. /// #[derive(ViolationMetadata)] pub(crate) struct InvalidFormatterSuppressionComment {