From caaaca6580670013f18805d0fc4cfc0ade079715 Mon Sep 17 00:00:00 2001 From: Carl Meyer Date: Fri, 18 Apr 2025 15:26:04 -0700 Subject: [PATCH 01/10] [red-knot] update mypy-primer projects list --- .../resources/primer/bad.txt | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 crates/red_knot_python_semantic/resources/primer/bad.txt diff --git a/crates/red_knot_python_semantic/resources/primer/bad.txt b/crates/red_knot_python_semantic/resources/primer/bad.txt new file mode 100644 index 0000000000000..ea337759c41eb --- /dev/null +++ b/crates/red_knot_python_semantic/resources/primer/bad.txt @@ -0,0 +1,33 @@ +Tanjun # hangs? +aiohttp # missing expression ID +alerta # missing expression ID +altair # cycle panics (try_metaclass_) +antidote # hangs / slow +artigraph # cycle panics (value_type_) +cpython # missing expression ID, access to field whilst being initialized, too many cycle iterations +colour # cycle panics (try_metaclass_) +core # cycle panics (value_type_) +discord.py # some kind of hang, only when multi-threaded? +dragonchain # too many cycle iterations (member_lookup_with_policy) +manticore # stack overflow +materialize # stack overflow +meson # missing expression ID +mypy # cycle panic (signature_) +pandas # too many cycle iterations (member_lookup_with_policy) +pandas-stubs # cycle panics (try_metaclass) +pip # too many cycle iterations (infer_expression_types) +poetry # too many cycle iterations (member_lookup_with_policy, infer_expression_type) +prefect # slow +pytest # cycle panics (signature_), missing expression ID +pywin32 # bad use-def map (binding with definitely-visible unbound) +schemathesis # cycle panics (signature_) +scikit-learn # success, but mypy-primer hangs processing the output +scipy # missing expression ID +setuptools # too many cycle iterations (infer_definition_types) +spack # success, but mypy-primer hangs processing the output +spark # missing expression ID +sphinx # missing expression ID +steam.py # missing expression ID +streamlit # cycle panic (signature) +sympy # stack overflow +trio # missing expression ID From 028e225e55bf1451f3c9e2c786721188f8f7c379 Mon Sep 17 00:00:00 2001 From: David Peter Date: Tue, 22 Apr 2025 13:43:30 +0200 Subject: [PATCH 02/10] Add five new try_metaclass_ cycle panics --- crates/red_knot_python_semantic/resources/primer/bad.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/crates/red_knot_python_semantic/resources/primer/bad.txt b/crates/red_knot_python_semantic/resources/primer/bad.txt index ea337759c41eb..eed3530c340fa 100644 --- a/crates/red_knot_python_semantic/resources/primer/bad.txt +++ b/crates/red_knot_python_semantic/resources/primer/bad.txt @@ -4,17 +4,21 @@ alerta # missing expression ID altair # cycle panics (try_metaclass_) antidote # hangs / slow artigraph # cycle panics (value_type_) -cpython # missing expression ID, access to field whilst being initialized, too many cycle iterations colour # cycle panics (try_metaclass_) core # cycle panics (value_type_) +cpython # missing expression ID, access to field whilst being initialized, too many cycle iterations discord.py # some kind of hang, only when multi-threaded? dragonchain # too many cycle iterations (member_lookup_with_policy) +freqtrade # cycle panics (try_metaclass_) +hydpy # cycle panics (try_metaclass_) +ibis # cycle panics (try_metaclass_) manticore # stack overflow materialize # stack overflow meson # missing expression ID mypy # cycle panic (signature_) pandas # too many cycle iterations (member_lookup_with_policy) -pandas-stubs # cycle panics (try_metaclass) +pandas-stubs # cycle panics (try_metaclass_) +pandera # cycle panics (try_metaclass_) pip # too many cycle iterations (infer_expression_types) poetry # too many cycle iterations (member_lookup_with_policy, infer_expression_type) prefect # slow @@ -31,3 +35,4 @@ steam.py # missing expression ID streamlit # cycle panic (signature) sympy # stack overflow trio # missing expression ID +xarray # cycle panics (try_metaclass_) From ed780f67004c14ff4bcca4b9de550195a7332435 Mon Sep 17 00:00:00 2001 From: David Peter Date: Tue, 22 Apr 2025 13:52:47 +0200 Subject: [PATCH 03/10] Tanjun also cycle panics --- crates/red_knot_python_semantic/resources/primer/bad.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/red_knot_python_semantic/resources/primer/bad.txt b/crates/red_knot_python_semantic/resources/primer/bad.txt index eed3530c340fa..d250b8e2a5ae6 100644 --- a/crates/red_knot_python_semantic/resources/primer/bad.txt +++ b/crates/red_knot_python_semantic/resources/primer/bad.txt @@ -1,4 +1,4 @@ -Tanjun # hangs? +Tanjun # cycle panic (signature_) aiohttp # missing expression ID alerta # missing expression ID altair # cycle panics (try_metaclass_) From fc52844c782bd5b310e5877653d92f2cce8f18f3 Mon Sep 17 00:00:00 2001 From: David Peter Date: Tue, 22 Apr 2025 13:53:01 +0200 Subject: [PATCH 04/10] dragonchain succeeds --- crates/red_knot_python_semantic/resources/primer/bad.txt | 1 - crates/red_knot_python_semantic/resources/primer/good.txt | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/red_knot_python_semantic/resources/primer/bad.txt b/crates/red_knot_python_semantic/resources/primer/bad.txt index d250b8e2a5ae6..3ce898a03de84 100644 --- a/crates/red_knot_python_semantic/resources/primer/bad.txt +++ b/crates/red_knot_python_semantic/resources/primer/bad.txt @@ -8,7 +8,6 @@ colour # cycle panics (try_metaclass_) core # cycle panics (value_type_) cpython # missing expression ID, access to field whilst being initialized, too many cycle iterations discord.py # some kind of hang, only when multi-threaded? -dragonchain # too many cycle iterations (member_lookup_with_policy) freqtrade # cycle panics (try_metaclass_) hydpy # cycle panics (try_metaclass_) ibis # cycle panics (try_metaclass_) diff --git a/crates/red_knot_python_semantic/resources/primer/good.txt b/crates/red_knot_python_semantic/resources/primer/good.txt index f1501dc9d5bfa..59e3509d747a0 100644 --- a/crates/red_knot_python_semantic/resources/primer/good.txt +++ b/crates/red_knot_python_semantic/resources/primer/good.txt @@ -30,6 +30,7 @@ dd-trace-py dedupe django-stubs downforeveryone +dragonchain dulwich flake8 flake8-pyi From ec40a94de17b192010090cc4d1dee94976116236 Mon Sep 17 00:00:00 2001 From: David Peter Date: Tue, 22 Apr 2025 13:57:34 +0200 Subject: [PATCH 05/10] pandas check succeeds, but slow to process in mypy_primer --- crates/red_knot_python_semantic/resources/primer/bad.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/red_knot_python_semantic/resources/primer/bad.txt b/crates/red_knot_python_semantic/resources/primer/bad.txt index 3ce898a03de84..f8e5b37b53bab 100644 --- a/crates/red_knot_python_semantic/resources/primer/bad.txt +++ b/crates/red_knot_python_semantic/resources/primer/bad.txt @@ -15,7 +15,7 @@ manticore # stack overflow materialize # stack overflow meson # missing expression ID mypy # cycle panic (signature_) -pandas # too many cycle iterations (member_lookup_with_policy) +pandas # slow pandas-stubs # cycle panics (try_metaclass_) pandera # cycle panics (try_metaclass_) pip # too many cycle iterations (infer_expression_types) From 6559e02ed38d6491609b49f5d7b3ca039785cf9a Mon Sep 17 00:00:00 2001 From: David Peter Date: Tue, 22 Apr 2025 13:59:00 +0200 Subject: [PATCH 06/10] Running on pip works --- crates/red_knot_python_semantic/resources/primer/bad.txt | 1 - crates/red_knot_python_semantic/resources/primer/good.txt | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/red_knot_python_semantic/resources/primer/bad.txt b/crates/red_knot_python_semantic/resources/primer/bad.txt index f8e5b37b53bab..002f1709c8f88 100644 --- a/crates/red_knot_python_semantic/resources/primer/bad.txt +++ b/crates/red_knot_python_semantic/resources/primer/bad.txt @@ -18,7 +18,6 @@ mypy # cycle panic (signature_) pandas # slow pandas-stubs # cycle panics (try_metaclass_) pandera # cycle panics (try_metaclass_) -pip # too many cycle iterations (infer_expression_types) poetry # too many cycle iterations (member_lookup_with_policy, infer_expression_type) prefect # slow pytest # cycle panics (signature_), missing expression ID diff --git a/crates/red_knot_python_semantic/resources/primer/good.txt b/crates/red_knot_python_semantic/resources/primer/good.txt index 59e3509d747a0..157399a4c0f32 100644 --- a/crates/red_knot_python_semantic/resources/primer/good.txt +++ b/crates/red_knot_python_semantic/resources/primer/good.txt @@ -65,6 +65,7 @@ packaging paroxython parso pegen +pip porcupine ppb-vector psycopg From 2cce0957e3e1f240c86de5158aee322989845ebe Mon Sep 17 00:00:00 2001 From: David Peter Date: Tue, 22 Apr 2025 13:59:45 +0200 Subject: [PATCH 07/10] Running on poetry works --- crates/red_knot_python_semantic/resources/primer/bad.txt | 1 - crates/red_knot_python_semantic/resources/primer/good.txt | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/red_knot_python_semantic/resources/primer/bad.txt b/crates/red_knot_python_semantic/resources/primer/bad.txt index 002f1709c8f88..a3201b4a82820 100644 --- a/crates/red_knot_python_semantic/resources/primer/bad.txt +++ b/crates/red_knot_python_semantic/resources/primer/bad.txt @@ -18,7 +18,6 @@ mypy # cycle panic (signature_) pandas # slow pandas-stubs # cycle panics (try_metaclass_) pandera # cycle panics (try_metaclass_) -poetry # too many cycle iterations (member_lookup_with_policy, infer_expression_type) prefect # slow pytest # cycle panics (signature_), missing expression ID pywin32 # bad use-def map (binding with definitely-visible unbound) diff --git a/crates/red_knot_python_semantic/resources/primer/good.txt b/crates/red_knot_python_semantic/resources/primer/good.txt index 157399a4c0f32..461e3e8d17a79 100644 --- a/crates/red_knot_python_semantic/resources/primer/good.txt +++ b/crates/red_knot_python_semantic/resources/primer/good.txt @@ -66,6 +66,7 @@ paroxython parso pegen pip +poetry porcupine ppb-vector psycopg From fbce5a79593705eca5920860c0d8afb0c332bfdf Mon Sep 17 00:00:00 2001 From: David Peter Date: Tue, 22 Apr 2025 14:02:09 +0200 Subject: [PATCH 08/10] Running on setuptools works --- crates/red_knot_python_semantic/resources/primer/bad.txt | 1 - crates/red_knot_python_semantic/resources/primer/good.txt | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/red_knot_python_semantic/resources/primer/bad.txt b/crates/red_knot_python_semantic/resources/primer/bad.txt index a3201b4a82820..f4fcac8493cd2 100644 --- a/crates/red_knot_python_semantic/resources/primer/bad.txt +++ b/crates/red_knot_python_semantic/resources/primer/bad.txt @@ -24,7 +24,6 @@ pywin32 # bad use-def map (binding with definitely-visible unbound) schemathesis # cycle panics (signature_) scikit-learn # success, but mypy-primer hangs processing the output scipy # missing expression ID -setuptools # too many cycle iterations (infer_definition_types) spack # success, but mypy-primer hangs processing the output spark # missing expression ID sphinx # missing expression ID diff --git a/crates/red_knot_python_semantic/resources/primer/good.txt b/crates/red_knot_python_semantic/resources/primer/good.txt index 461e3e8d17a79..2c7a36665a404 100644 --- a/crates/red_knot_python_semantic/resources/primer/good.txt +++ b/crates/red_knot_python_semantic/resources/primer/good.txt @@ -90,6 +90,7 @@ rich rotki schema_salad scrapy +setuptools sockeye speedrun.com_global_scoreboard_webapp starlette From 255b2998267198075667764351f8170eb1fba52e Mon Sep 17 00:00:00 2001 From: David Peter Date: Tue, 22 Apr 2025 14:03:31 +0200 Subject: [PATCH 09/10] spark is a cycle panic --- crates/red_knot_python_semantic/resources/primer/bad.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/red_knot_python_semantic/resources/primer/bad.txt b/crates/red_knot_python_semantic/resources/primer/bad.txt index f4fcac8493cd2..d17fdf4a549ae 100644 --- a/crates/red_knot_python_semantic/resources/primer/bad.txt +++ b/crates/red_knot_python_semantic/resources/primer/bad.txt @@ -25,7 +25,7 @@ schemathesis # cycle panics (signature_) scikit-learn # success, but mypy-primer hangs processing the output scipy # missing expression ID spack # success, but mypy-primer hangs processing the output -spark # missing expression ID +spark # cycle panics (try_metaclass_) sphinx # missing expression ID steam.py # missing expression ID streamlit # cycle panic (signature) From 8baaac823bcd24eb72ed8897c71a9b452dc4040b Mon Sep 17 00:00:00 2001 From: David Peter Date: Tue, 22 Apr 2025 14:04:45 +0200 Subject: [PATCH 10/10] Minor consistency change --- crates/red_knot_python_semantic/resources/primer/bad.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/red_knot_python_semantic/resources/primer/bad.txt b/crates/red_knot_python_semantic/resources/primer/bad.txt index d17fdf4a549ae..d263c922c9186 100644 --- a/crates/red_knot_python_semantic/resources/primer/bad.txt +++ b/crates/red_knot_python_semantic/resources/primer/bad.txt @@ -28,7 +28,7 @@ spack # success, but mypy-primer hangs processing the output spark # cycle panics (try_metaclass_) sphinx # missing expression ID steam.py # missing expression ID -streamlit # cycle panic (signature) +streamlit # cycle panic (signature_) sympy # stack overflow trio # missing expression ID xarray # cycle panics (try_metaclass_)