Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📋 Black-compatible formatting of django #6069

Closed
20 tasks done
konstin opened this issue Jul 25, 2023 · 4 comments
Closed
20 tasks done

📋 Black-compatible formatting of django #6069

konstin opened this issue Jul 25, 2023 · 4 comments
Labels
formatter Related to the formatter

Comments

@konstin
Copy link
Member

konstin commented Jul 25, 2023

We would like to format the black-user django as closely to black as possible. Below is a list the bugs to be solved and features necessary to reach black compatibility on django. This list is manually curated by checking git diff after cargo run --bin ruff_dev -- format-dev --write django

Larger features

Comment placement

Breakpoints/grouping

Other

@konstin konstin added the formatter Related to the formatter label Jul 25, 2023
@MichaReiser MichaReiser added the help wanted Contributions especially welcome label Jul 31, 2023
@MichaReiser MichaReiser added this to the Formatter: Alpha milestone Jul 31, 2023
@konstin konstin removed their assignment Jul 31, 2023
@konstin
Copy link
Member Author

konstin commented Aug 11, 2023

i went through the diff again an added some that i previously missed

@MichaReiser
Copy link
Member

MichaReiser commented Aug 29, 2023

We don't plan on fixing the following black deviations because we believe that Ruff's formatting is more readable and implementing Black's formatting would require special handling.

@MichaReiser MichaReiser removed the help wanted Contributions especially welcome label Sep 12, 2023
@MichaReiser
Copy link
Member

@konstin should we close this issue or do you want to do another pass?

@konstin konstin closed this as completed Sep 13, 2023
@konstin
Copy link
Member Author

konstin commented Sep 13, 2023

I want to shift focus to user reports and prioritize from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

No branches or pull requests

2 participants