Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should cursor credit rustc? #12107

Closed
sbdchd opened this issue Jun 29, 2024 · 2 comments · Fixed by #12109
Closed

Should cursor credit rustc? #12107

sbdchd opened this issue Jun 29, 2024 · 2 comments · Fixed by #12109
Labels
parser Related to the parser question Asking for support or clarification

Comments

@sbdchd
Copy link
Contributor

sbdchd commented Jun 29, 2024

@AlexWaygood AlexWaygood added the parser Related to the parser label Jun 29, 2024
@zanieb
Copy link
Member

zanieb commented Jun 29, 2024

👋 I went on quite the hunt trying to see if there was context about this. As far as I can tell nobody talked about the rustc lexer and they probably would have if they based the design on it? I'm curious to hear from @MichaReiser though.

Some references I looked at:

@zanieb zanieb added the question Asking for support or clarification label Jun 29, 2024
@MichaReiser
Copy link
Member

Yes, we absolutely should.

I was fairly certain that I mentioned in some comment that the implementation is derived from Rust in #4922 (inline comment or at least on the PR), but I didn't!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser Related to the parser question Asking for support or clarification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants