use is_known_dunder_method instead

Author: randolf-scholz

crates/ruff_linter/resources/test/fixtures/flake8_boolean_trap/FBT.py

@@ -93,18 +93,6 @@ def foo(self, value: bool) -> None:
     def foo(self) -> None:
         object.__setattr__(self, "flag", True)
 
-    def __and__(self, other: bool) -> bool: ...
-    def __rand__(self, other: bool) -> bool: ...
-    def __iand__(self, other: bool) -> bool: ...
-    def __or__(self, other: bool) -> bool: ...
-    def __ror__(self, other: bool) -> bool: ...
-    def __ior__(self, other: bool) -> bool: ...
-    def __xor__(self, other: bool) -> bool: ...
-    def __rxor__(self, other: bool) -> bool: ...
-    def __ixor__(self, other: bool) -> bool: ...
-
-
-
 
 from typing import Optional, Union
 
@@ -166,3 +154,17 @@ def __post_init__(self, force: bool) -> None:
 
 class Settings(BaseSettings):
     foo: bool = Field(True, exclude=True)
+
+
+# https://github.com/astral-sh/ruff/issues/14202
+class SupportsOperators:
+
+    def __and__(self, other: bool) -> bool: ...
+    def __rand__(self, other: bool) -> bool: ...
+    def __iand__(self, other: bool) -> bool: ...
+    def __or__(self, other: bool) -> bool: ...
+    def __ror__(self, other: bool) -> bool: ...
+    def __ior__(self, other: bool) -> bool: ...
+    def __xor__(self, other: bool) -> bool: ...
+    def __rxor__(self, other: bool) -> bool: ...
+    def __ixor__(self, other: bool) -> bool: ...

crates/ruff_linter/src/rules/flake8_boolean_trap/helpers.rs

@@ -3,6 +3,7 @@ use ruff_python_ast::{self as ast, Expr};
 use ruff_python_semantic::SemanticModel;
 
 use crate::checkers::ast::Checker;
+use crate::rules::pylint::helpers::is_known_dunder_method;
 use crate::settings::LinterSettings;
 
 /// Returns `true` if a function call is allowed to use a boolean trap.
@@ -68,21 +69,7 @@ pub(super) fn is_user_allowed_func_call(
 
 /// Returns `true` if a function definition is allowed to use a boolean trap.
 pub(super) fn is_allowed_func_def(name: &str) -> bool {
-    matches!(
-        name,
-        "__setitem__"
-            | "__post_init__"
-            // exclude boolean operators
-            | "__and__"
-            | "__rand__"
-            | "__iand__"
-            | "__or__"
-            | "__ror__"
-            | "__ior__"
-            | "__xor__"
-            | "__rxor__"
-            | "__ixor__"
-    )
+    is_known_dunder_method(name)
 }
 
 /// Returns `true` if an argument is allowed to use a boolean trap. To return

crates/ruff_linter/src/rules/pylint/helpers.rs

@@ -167,7 +167,7 @@ impl<'a> Visitor<'_> for SequenceIndexVisitor<'a> {
 }
 
 /// Returns `true` if a method is a known dunder method.
-pub(super) fn is_known_dunder_method(method: &str) -> bool {
+pub(crate) fn is_known_dunder_method(method: &str) -> bool {
     matches!(
         method,
         "__abs__"

crates/ruff_linter/src/rules/pylint/mod.rs

@@ -1,5 +1,5 @@
 //! Rules from [Pylint](https://pypi.org/project/pylint/).
-mod helpers;
+pub(crate) mod helpers;
 pub(crate) mod rules;
 pub mod settings;