Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming 1.0 and renaming #23

Open
lissyx opened this issue Aug 6, 2020 · 11 comments
Open

Upcoming 1.0 and renaming #23

lissyx opened this issue Aug 6, 2020 · 11 comments
Assignees

Comments

@lissyx
Copy link
Contributor

lissyx commented Aug 6, 2020

Hello,

1.0 is close, and part of the work for that involves one painful change: we need to rename the project to Mozilla Voice STT.
It also means library itself and the API need to get renamed: libdeepspeech.so -> libmozilla_voice_stt.so and API DS_* becomes STT_*.

Besides this renaming, there should be no other change. I can help and prepare a PR to update once we have completed some painful renaming on our side (CI, packages everywhere).

For clarity, it might be good if you could rename your binding as well, but we do not want to force you as well.

@asticode asticode self-assigned this Aug 9, 2020
@asticode
Copy link
Owner

asticode commented Aug 9, 2020

OK good to know, your help would be greatly appreciated!

What do you have in mind in terms of renaming the binding?

@lissyx
Copy link
Contributor Author

lissyx commented Aug 9, 2020

Other binding switched to use mozilla-voice-stt for consistency with us, so if it works for you thats our suggestion 😊

@asticode
Copy link
Owner

asticode commented Aug 9, 2020

Did they rename their repo as well?

@lissyx
Copy link
Contributor Author

lissyx commented Aug 9, 2020

I dont think they acted yet, and it really depends on you and your users, if you think its okay to rename your repo or if it's going to be too much of a mess. We will rename ours, though.

@asticode
Copy link
Owner

OK, I won't rename the repo for now. I'll wait for your PR then

@go-dockly
Copy link

go-dockly commented Oct 23, 2021

I created a PR for this so we can finally close this issue.
@lissyx could you add a link to astideepspeech back on your examples web page once the PR is merged?

Thanks for the fantastic work guys!

@lissyx
Copy link
Contributor Author

lissyx commented Oct 25, 2021

I created a PR for this so we can finally close this issue. @lissyx could you add a link to astideepspeech back on your examples web page once the PR is merged?

? I don't understand your request.

@go-dockly
Copy link

go-dockly commented Oct 25, 2021

@lissyx on this How is Coqui STT implemented? page the golang bindings are still mentioned but the link to this repo has disappeared.
Since asti's bindings work against v1.0 now it would be nice to link back to this repo in the examples section.

@lissyx
Copy link
Contributor Author

lissyx commented Oct 26, 2021

@lissyx on this How is Coqui STT implemented? page the golang bindings are still mentioned but the link to this repo has disappeared. Since asti's bindings work against v1.0 now it would be nice to link back to this repo in the examples section.

I am not working on Coqui, you should ask @reuben

@reuben
Copy link

reuben commented Oct 26, 2021

We'll be happy to re-link to the bindings once the PR is reviewed and merged!

@asticode
Copy link
Owner

asticode commented Nov 1, 2021

FYI I've merged the PR. URL to the repo is https://github.com/asticode/go-asticoqui

Thanks in advance for any re-link ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants