This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
React to HttpAbstractions change: No features in .Internal namespace
#749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dougbu, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| @@ -5,6 +5,7 @@ | |||
| using System.Threading.Tasks; | |||
| using Microsoft.AspNetCore.Builder; | |||
| using Microsoft.AspNetCore.Http; | |||
| using Microsoft.AspNetCore.Http.Features; | |||
| using Microsoft.AspNetCore.Http.Features.Internal; | |||
There was a problem hiding this comment.
See line 30 in this file. The class references both IResponseCookiesFeature and the concrete ResponseCookiesFeature. (As I mentioned in aspnet/HttpAbstractions#549, many of our repos use supposedly-internal classes and interfaces from HttpAbstractions.)
|
|
dougbu
force-pushed
the
dougbu/feature.interfaces.561
branch
from
91c4d47
to
9361960
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseCookies.Append()allocates lots, big lots HttpAbstractions#561 and pull Move remaining feature interfaces intoMicrosoft.AspNetCore.Http.Featurespackage and namespace HttpAbstractions#589