Vary by *

Author: JunTaoLuo

src/Microsoft.AspNetCore.ResponseCaching/ResponseCachingContext.cs

@@ -4,6 +4,7 @@
 using System;
 using System.IO;
 using System.Globalization;
+using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Http;
@@ -178,25 +179,39 @@ internal string CreateCacheKey(CachedVaryBy varyBy)
                     }
                 }
 
-                // Vary by params
+                // Vary by query params
                 if (varyBy?.Params.Count > 0)
                 {
-                    // TODO: resolve key format and delimiters
-                    foreach (var param in varyBy.Params)
+                    if (varyBy.Params.Count == 1 && string.Equals(varyBy.Params[0], "*", StringComparison.OrdinalIgnoreCase))
                     {
-                        // TODO: Normalization of order, case?
-                        var value = _httpContext.Request.Query[param];
-
-                        // TODO: How to handle null/empty string?
-                        if (StringValues.IsNullOrEmpty(value))
+                        // Vary by all available query params
+                        foreach (var query in _httpContext.Request.Query.OrderBy(q => q.Key))
                         {
-                            value = "null";
+                            builder.Append(";")
+                                .Append(query.Key)
+                                .Append("=")
+                                .Append(query.Value);
+                        }
+                    }
+                    else
+                    {
+                        // TODO: resolve key format and delimiters
+                        foreach (var param in varyBy.Params)
+                        {
+                            // TODO: Normalization of order, case?
+                            var value = _httpContext.Request.Query[param];
+
+                            // TODO: How to handle null/empty string?
+                            if (StringValues.IsNullOrEmpty(value))
+                            {
+                                value = "null";
+                            }
+
+                            builder.Append(";")
+                                .Append(param)
+                                .Append("=")
+                                .Append(value);
                         }
-
-                        builder.Append(";")
-                            .Append(param)
-                            .Append("=")
-                            .Append(value);
                     }
                 }
 

test/Microsoft.AspNetCore.ResponseCaching.Tests/ResponseCachingContextTests.cs

@@ -205,6 +205,21 @@ public void CreateCacheKey_Includes_ListedVaryByParamsOnly()
             }));
         }
 
+        [Fact]
+        public void CreateCacheKey_Includes_AllQueryParamsGivenAsterisk()
+        {
+            var httpContext = new DefaultHttpContext();
+            httpContext.Request.Method = "GET";
+            httpContext.Request.Path = "/";
+            httpContext.Request.QueryString = new QueryString("?ParamA=ValueA&ParamB=ValueB");
+            var context = CreateTestContext(httpContext);
+
+            Assert.Equal("GET;/;ParamA=ValueA;ParamB=ValueB", context.CreateCacheKey(new CachedVaryBy()
+            {
+                Params = new string[] { "*" }
+            }));
+        }
+
         [Fact]
         public void CreateCacheKey_Includes_ListedVaryByHeadersAndParams()
         {