Feedback

Author: JunTaoLuo

samples/ResponseCachingSample/Startup.cs

@@ -27,9 +27,9 @@ public void Configure(IApplicationBuilder app)
                 context.Response.GetTypedHeaders().CacheControl = new CacheControlHeaderValue()
                 {
                     Public = true,
-                    MaxAge = TimeSpan.FromSeconds(10)                    
+                    MaxAge = TimeSpan.FromSeconds(10)
                 };
-                context.Response.GetTypedHeaders().AppendList("Vary", new string[] { "Accept-Encoding", "Non-Existent" });
+                context.Response.Headers["Vary"] = new string[] { "Accept-Encoding", "Non-Existent" };
 
                 await context.Response.WriteAsync("Hello World! " + DateTime.UtcNow);
             });

src/Microsoft.AspNetCore.ResponseCaching/ResponseCache/CachedResponse.cs

@@ -9,8 +9,6 @@ public class CachedResponse : IResponseCacheEntry
     {
         public string Key { get; set; }
 
-        public ResponseCacheEntryType Type => ResponseCacheEntryType.Response;
-
         public int StatusCode { get; set; }
 
         internal IHeaderDictionary Headers { get; set; } = new HeaderDictionary();

src/Microsoft.AspNetCore.ResponseCaching/ResponseCache/CachedVaryBy.cs

@@ -9,8 +9,6 @@ public class CachedVaryBy : IResponseCacheEntry
     {
         public string Key { get; set; }
 
-        public ResponseCacheEntryType Type => ResponseCacheEntryType.VaryBy;
-
         public StringValues Headers { get; set; }
     }
 }

src/Microsoft.AspNetCore.ResponseCaching/ResponseCache/DefaultResponseCacheEntrySerializer.cs

@@ -48,15 +48,15 @@ public static IResponseCacheEntry Read(BinaryReader reader)
             }
 
             var key = reader.ReadString();
-            var type = (ResponseCacheEntryType)reader.ReadInt32();
+            var type = reader.ReadString();
 
-            if (type == ResponseCacheEntryType.Response)
+            if (string.Equals(nameof(CachedResponse), type))
             {
                 var cachedResponse = ReadCachedResponse(reader);
                 cachedResponse.Key = key;
                 return cachedResponse;
             }
-            else if (type == ResponseCacheEntryType.VaryBy)
+            else if (string.Equals(nameof(CachedVaryBy), type))
             {
                 var cachedResponse = ReadCachedVaryBy(reader);
                 cachedResponse.Key = key;
@@ -105,14 +105,15 @@ public static void Write(BinaryWriter writer, IResponseCacheEntry entry)
 
             writer.Write(FormatVersion);
             writer.Write(entry.Key);
-            writer.Write((int)entry.Type);
 
             if (entry is CachedResponse)
             {
+                writer.Write(nameof(CachedResponse));
                 WriteCachedResponse(writer, entry as CachedResponse);
             }
             else if (entry is CachedVaryBy)
             {
+                writer.Write(nameof(CachedVaryBy));
                 WriteCachedVaryBy(writer, entry as CachedVaryBy);
             }
         }

src/Microsoft.AspNetCore.ResponseCaching/ResponseCache/IResponseCacheEntry.cs

@@ -6,6 +6,5 @@ namespace Microsoft.AspNetCore.ResponseCaching
     public interface IResponseCacheEntry
     {
         string Key { get; set; }
-        ResponseCacheEntryType Type { get; }
     }
 }