De-dupe TagHelperDescriptors based on Type for rendering. #327
Conversation
- This can occur if you have multiple [TargetElement] attributes that overlap. Ultimately the descriptor is the same because its the same type, just the required attributes differ. - Added tests to validate. #326
ghost
added
the
|
Getting this in now, feel free to leave comments. I'll do a commit to address any feedback. /cc @ajaybhargavb you should be good now 😄 |
| attributes: new TagHelperAttributeDescriptor[] | ||
| { | ||
| new TagHelperAttributeDescriptor("type", inputTypePropertyInfo), | ||
| new TagHelperAttributeDescriptor("checked", inputCheckedPropertyInfo) |
There was a problem hiding this comment.
tiny nit: this looks like the tag helper author just wrote an extra, useless [TargetElement]. a more realistic scenario would involve something like [TargetElement(Attributes = "type")] and [TargetElement(Attributes = "checked")] on the same helper. the author didn't do anything wrong in this case but <whatever type="type" checked="checked" /> would lead to duplication.
so, minor leaning toward removing lines 45 and 64
There was a problem hiding this comment.
Actualllly there's a flaw in the test here. If the TagHelper type is the same type the attribute descriptors will all be the same. Will update and get it into dev.
|
|
Multiple [TargetElement] attributes on a single TagHelper should de-dup if multiple match. #326