This repository has been archived by the owner on Nov 29, 2018. It is now read-only.
Add IStringLocalizer.GetAllStrings method #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| foreach (var name in resourceNames) | ||
| { | ||
| var value = GetStringSafely(name, culture); | ||
| yield return new LocalizedString(name, value ?? name, resourceNotFound: value == null); |
There was a problem hiding this comment.
According to the function definition https://github.com/aspnet/Localization/blob/dev/src/Microsoft.Framework.Localization.Abstractions/LocalizedString.cs#L30 I don't think that we need the named parameter resourceNotFound while you didn't change the order of the parameters
There was a problem hiding this comment.
We always tend to name args when we pass in bool or null values.
|
I think we should do #23 in this PR. |
|
@hishamco that's what the extension method achieves https://github.com/aspnet/Localization/pull/22/files#diff-fd6180fc301d656a5a25bc6d20b88a50R38 |
|
👍 |
DamianEdwards
force-pushed
the
damian/GetStringsMethod
branch
from
54540f9 to
f830a15
Compare
| /// Gets all string resources including those for ancestor cultures. | ||
| /// </summary> | ||
| /// <param name="stringLocalizer">The <see cref="IStringLocalizer"/>.</param> | ||
| /// <returns></returns> |
There was a problem hiding this comment.
<returns> should have some text. May be "The strings" like above?
|
|
1 similar comment
|
|
DamianEdwards
force-pushed
the
damian/GetStringsMethod
branch
from
20c6d18 to
1a47d19
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidfowl @muratg
#18 #23