Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

Commit

Permalink
Switch to xunit.runner.aspnet
Browse files Browse the repository at this point in the history
  • Loading branch information
@analogrelay
analogrelay committed Jun 13, 2015
1 parent f581863 commit d436955
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions test/Microsoft.Framework.Localization.Test/project.json
View file
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
{
"dependencies": {
"xunit": "2.1.0-*",
"xunit.runner.dnx": "2.1.0-*",
"xunit.runner.aspnet": "2.0.0-aspnet-*",
"Microsoft.Framework.Localization": "1.0.0-*"
},

"commands": {
"test": "xunit.runner.dnx"
"test": "xunit.runner.aspnet"
},

"frameworks": {
"dnx451": { },
"dnxcore50": {
"dnxcore50": {
"dependencies": {
"System.Reflection": "4.0.10-beta-*"
}
Expand Down

5 comments on commit d436955

@davidfowl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@analogrelay
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because otherwise the Localization build was failing in release? Maybe I misunderstand the difference but it seemed that most other repos used aspnet

@DamianEdwards
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change shouldn't be made. The whole point in using the public xunit builds is so we find and fix issues that customers will face. Please investigate the failure and work to fix the underlying issue. If we broke the xunit DNX runner we need to fix it by sending them a PR or fixing our break.

@davidfowl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this isn't right.

@analogrelay
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #33 - For the record it's extraordinarily unclear to me which is the official build :P.

Please sign in to comment.