This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Added "308 Permanent Redirect" to ReasonPhrases #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, are you interested in a PR for "451 Unavailable For Legal Reasons" (RFC7725)? I see it's missing from the HTTP abstractions as well... |
|
🚢 |
|
@muratg @Eilon @davidfowl What's your take on 451? |
|
|
308 seems like a pretty safe. I would take 451 too because why not?
|
Submitted 451 as well... #930 |
|
Seems safe and nice to me too. Though bar for 1.0.0 is very high now, so we'll get this in once we branch for RTM. |
|
Let's merge this. 🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From RFC7538 - https://tools.ietf.org/html/rfc7538