Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Consider exposing IHttpConnectionFeature.ConnectionId through ConnectionInfo #827

Closed
khellang opened this issue Apr 25, 2017 · 2 comments
Closed

Comments

@khellang
Copy link
Contributor

What it says on the tin. Is there a reason this isn't exposed through the HttpContext surface?

@davidfowl
Copy link
Member

It's not very common to care about the underlying connection id when logging. It's especially less relevant with http2 since it's the same connection for all requests. Why does it need to be first class?

@khellang
Copy link
Contributor Author

khellang commented Apr 25, 2017

It's not very common to care about the underlying connection id when logging.

I use it all the time when working with WebSockets. Wasn't that (logging) the reason for it to be added in the first place? (#542)

Why does it need to be first class?

It doesn't need to be first class, but it would be convenient. HttpContext.Features.Get<IHttpConnectionFeature>().ConnectionId is pretty verbose (yes, I have an extension method for it, but still) 😢

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants